Skip to content

fix: backward-compat for ESM etherpad #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SamTV12345 merged 1 commit into from
May 25, 2026
Merged

fix: backward-compat for ESM etherpad #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eejs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';

const eejs = require('ep_etherpad-lite/node/eejs/');
const eejs = require('ep_etherpad-lite/node/eejs');
Copy link
Copy Markdown

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects Bot May 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. No regression test for require 📘 Rule violation ≡ Correctness

This PR changes the eejs import path to fix ESM exports-map resolution, but it does not add or
update any automated test to prevent the bug from being reintroduced. Without a regression test, the
compatibility break could recur unnoticed in future refactors/releases.
Agent Prompt 
## Issue description
A bug fix was made (removing the trailing slash in `require('ep_etherpad-lite/node/eejs')`), but no regression test was added/updated in the same change set.

## Issue Context
Per the compliance checklist, every bug fix must include an automated regression test that would fail before the fix and pass after it. This PR only changes runtime code (and bumps the package version) without adding any test coverage for the import-path compatibility issue.

## Fix Focus Areas
- eejs.js[3-3]
- static/tests/backend/specs/esm-eejs-require.spec.js[1-120]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

const settings = require('ep_etherpad-lite/node/utils/Settings');

exports.eejsBlock_styles = (hook_name, args, cb) => {
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "ep_print",
"description": "Support for printing, works cross browser, supports page breaks",
"version": "11.0.21",
"version": "11.0.22",
"author": {
"name": "johnyma22",
"email": "john@mclear.co.uk",
Expand Down
Loading