feat(padToggle): honor runtime settings.enablePluginPadOptions flag#9
Merged
JohnMcLear merged 1 commit intomainfrom May 7, 2026
Merged
feat(padToggle): honor runtime settings.enablePluginPadOptions flag#9JohnMcLear merged 1 commit intomainfrom
JohnMcLear merged 1 commit intomainfrom
Conversation
etherpad-lite #7698 (merged) added a feature flag — settings.enablePluginPadOptions, default false per AGENTS.MD §52 — that gates the ep_* padOptions passthrough at runtime. The helper was only checking the static PluginCapabilities flag (capability present in core) and not the runtime gate, so on a patched core where the admin hasn't opted in the helper would still render the pad-wide checkbox even though the broadcast/persist path was off. Read the flag from loadSettings's args.settings.enablePluginPadOptions and feed it into both eejsBlock_padSettings (no-op when off) and the clientVars padWideSupported flag (lets the client wire correctly). Tests cover three scenarios on top of the existing patch-not-installed case: - core unpatched (existing): no-op, capability=false - core patched + flag missing: no-op, capability=false - clientVars reports padWideSupported=false when flag is off Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ether/etherpad#7698 (merged) added
settings.enablePluginPadOptions(default false per AGENTS.MD §52) as the runtime gate on theep_*padOptions passthrough. The helper was only checking the staticPluginCapabilitiesflag (capability present in core) and not the runtime gate — so on a patched core where the admin hasn't opted in, the helper would still render the pad-wide checkbox even though the broadcast/persist path is off. Click → silent no-op → confused users.Read the flag from
loadSettings'sargs.settings.enablePluginPadOptionsand feed it into both:eejsBlock_padSettings— no-op when off (no checkbox rendered).clientVars.ep_plugin_helpers.padToggle.<plugin>.padWideSupported— false when off, so the client'sinit()correctly skips wiring the pad-wide handler and logs the degradation warning instead.Test plan
🤖 Generated with Claude Code