ci: switch pnpm/action-setup to packageManager-only#191
Merged
Conversation
Pinning pnpm version on the action while ether/etherpad-lite's package.json has "packageManager": "pnpm@11.0.6" triggers ERR_PNPM_BAD_PM_VERSION regardless of the pinned value. Drop the version pin and (for workflows that check out etherpad-lite into ./etherpad-lite/) point the action at the core's package.json so it reads the canonical version from packageManager.
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm/action-setup@v6errors withERR_PNPM_BAD_PM_VERSIONwhen bothversion:is set on the action andpackageManager:is set in package.json — regardless of whether the values match.ether/etherpad-lite's package.json declarespackageManager: pnpm@11.0.6, so the conflict bites every plugin's CI.This PR drops the
version:pin so pnpm/action-setup@v6 reads the canonical version frompackageManager. For test workflows that check out etherpad-lite into./etherpad-lite/, also addspackage_json_file: ./etherpad-lite/package.jsonso the action can locate the file (since cwd has no package.json at install time).Verified green on ether/ep_dynamic_default_content.