Skip to content

fix: backward-compat for ESM etherpad #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SamTV12345 merged 1 commit into from
May 25, 2026
Merged

fix: backward-compat for ESM etherpad #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"email": "john@mclear.co.uk",
"url": "http://mclear.co.uk"
},
"version": "1.1.61",
"version": "1.1.62",
"repository": {
"type": "git",
"url": "https://github.com/ether/ep_help_bubbles.git"
Expand Down
10 changes: 5 additions & 5 deletions static/js/help_bubbles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,23 @@
'use strict';

exports.eejsBlock_scripts = (hookName, args, cb) => {
args.content += require('ep_etherpad-lite/node/eejs/')
args.content += require('ep_etherpad-lite/node/eejs')
.require('ep_help_bubbles/static/js/Bubble.js');
args.content += require('ep_etherpad-lite/node/eejs/')
args.content += require('ep_etherpad-lite/node/eejs')
.require('ep_help_bubbles/static/js/jquery.grumble.js');
args.content += require('ep_etherpad-lite/node/eejs/')
args.content += require('ep_etherpad-lite/node/eejs')
.require('ep_help_bubbles/static/js/help_bubbles_function.js');
Comment on lines +4 to 9
Copy link
Copy Markdown

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects Bot May 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. No regression test for eejs require 📘 Rule violation ☼ Reliability

This PR changes runtime module resolution behavior (removing the trailing slash in
require('ep_etherpad-lite/node/eejs')) but does not add or update an automated regression test to
prevent the bug from reappearing. This increases the risk of the ESM compatibility issue being
reintroduced without detection.
Agent Prompt 
## Issue description
A bug fix was made to module resolution (`require('ep_etherpad-lite/node/eejs')` path change) without adding a regression test that would fail before the fix and pass after it.

## Issue Context
The PR claims the trailing-slash form breaks under strict ESM exports map resolution. A regression test should exercise loading/including the plugin assets in a way that would catch a reintroduction of the trailing slash (or other incompatible import path changes).

## Fix Focus Areas
- static/js/help_bubbles.js[4-9]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

cb();
};

exports.eejsBlock_styles = (hookName, args, cb) => {
args.content += require('ep_etherpad-lite/node/eejs/')
args.content += require('ep_etherpad-lite/node/eejs')
.require('ep_help_bubbles/static/css/help_bubbles.css');
cb();
};

exports.eejsBlock_editbarMenuRight = (hookName, args, cb) => {
args.content = require('ep_etherpad-lite/node/eejs/')
args.content = require('ep_etherpad-lite/node/eejs')
.require('ep_help_bubbles/templates/help_bubbles.ejs') + args.content;
cb();
};
Loading