Skip to content

fix: backward-compat for ESM etherpad #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SamTV12345 merged 1 commit into from
May 25, 2026
Merged

fix: backward-compat for ESM etherpad #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eejs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';

const eejs = require('ep_etherpad-lite/node/eejs/');
const eejs = require('ep_etherpad-lite/node/eejs');
Copy link
Copy Markdown

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects Bot May 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. No regression test for eejs require 📘 Rule violation ☼ Reliability

This PR changes module resolution behavior by updating the require('ep_etherpad-lite/node/eejs')
path, but it does not add or update any automated regression test to ensure the ESM exports-map
compatibility issue stays fixed. Without a test, the trailing-slash behavior could be reintroduced
unnoticed.
Agent Prompt 
## Issue description
A bug fix was made (changing the `eejs` require path for ESM exports-map compatibility) but no regression test was added/updated in the same PR to prevent the issue from returning.

## Issue Context
The PR changes `require('ep_etherpad-lite/node/eejs/')` to `require('ep_etherpad-lite/node/eejs')`. Add an automated test that would have failed before this change (detecting the trailing-slash import) and passes now.

## Fix Focus Areas
- eejs.js[3-3]
- package.json[22-25]
- test/esm-compat.test.js[1-120]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


exports.eejsBlock_body = (hookName, args, cb) => {
args.content += eejs.require('ep_git_commit_saved_revision/templates/modals.ejs');
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "ep_git_commit_saved_revision",
"description": "Hooks on Saved Revision calls, designed to git commit a pad text when a user clicks Saved Revision Star",
"version": "11.0.24",
"version": "11.0.25",
"author": "johnyma22 (John McLear) <john@mclear.co.uk>",
"engines": {
"node": ">=18.0.0"
Expand Down
Loading