Skip to content

fix: backward-compat for ESM etherpad #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SamTV12345 merged 1 commit into from
May 25, 2026
Merged

fix: backward-compat for ESM etherpad #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eejs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';

const eejs = require('ep_etherpad-lite/node/eejs/');
const eejs = require('ep_etherpad-lite/node/eejs');
Copy link
Copy Markdown

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects Bot May 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. No regression test added 📘 Rule violation ☼ Reliability

The PR changes production code in eejs.js but does not add or update any automated regression test
in the same commit. This risks the ESM/CJS compatibility fix regressing without detection.
Agent Prompt 
## Issue description
A production bug fix was made (changing the `require()` path for `eejs`) without adding/updating a regression test in the same commit.

## Issue Context
The fix is intended to be backward-compatible and to work under Node's strict ESM exports map resolution; a test should fail with the trailing-slash path and pass with the new path.

## Fix Focus Areas
- eejs.js[3-3]
- (add) a new or updated test file under the project's existing test location (e.g., `static/tests/` or the plugin’s test harness) that exercises loading `eejs` and would have failed before this change

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


exports.eejsBlock_styles = (hookName, args, cb) => {
const css = eejs.require(
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "ep_file_menu_toolbar",
"description": "File / Menu style toolbar",
"version": "0.2.53",
"version": "0.2.54",
"author": "johnyma22 (John McLear) <john@mclear.co.uk>",
"engines": {
"node": ">=18.0.0"
Expand Down
Loading