docs: add AppFlush trait design document#31
Merged
Merged
Conversation
Design for fixing observer nodes not flushing pending state to the merkle trie. Adds AppFlush trait to allow framework to flush app state for observers without requiring proof generation. <!-- ps-id: d9634340-0b82-47b8-8db0-d2ecabae350d -->
Observers don't generate proofs, so flush() was never called after state transitions. This caused API inconsistencies where get_balance worked (reads from pending writes) but get_burn_proof returned null (only reads from flushed trie). - Add AppFlush trait to transitions.rs - Add App: AppFlush bounds to observer/optimistic functions - Call flush() after api_update in observer_state_transition_with_storage - Implement AppFlush for increment and transfers apps (no-op) <!-- ps-id: 9126455a-c2b8-4070-a96b-c987a02571b9 -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.