[JAY-706] Add #clone to QueryBuilder #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a #clone method to the QueryBuilder class. The method properly clones the QueryBuilder instance and its nested objects. Without this method when #clone was called on a QueryBuilder object, changes to the clone's query, aggregations, sort and, in certain cases, source clauses would propagate to the original object. With the addition of the #clone method these issues no longer happen.
sergio-bobillier
force-pushed
the
sb-JAY-706-clone-query-builder
branch
from
0ea4faa to
343a96f
Compare
sheputis
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
#clonemethod to theQueryBuilderclass. The method properly clones theQueryBuilderinstance and its nested objects.Without this method when
#clonewas called on aQueryBuilderobject, changes to the clone'squery,aggregations,sortand, in certain cases,sourceclauses would propagate to the original object.With the addition of the
#clonemethod these issues no longer happen.