[JAY-678] Allow sort options in QueryBuilder#sort #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the QueryBuilder#sort method to accept sort options as a hash in addition to the existing string format. This allows the user to pass advanced sort options like 'missing', 'mode', 'unmapped_type', etc. The main driver behind this change is the multiple-index search feature that was added with JAY-676 (957a473). When searching across multiple indexes, it's important to handle cases where a field might be missing in some indexes. By allowing sort options, users can now specify how to handle this scenario. Without this possibility queries will just fail if a field is missing in one of the indexes.
sergio-bobillier
force-pushed
the
sb-JAY-678-allow-sort-options
branch
from
42e70e4 to
aa81edc
Compare
sheputis
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the
QueryBuilder#sortmethod to accept sort options as a hash in addition to the existing string format. This allows the user to pass advanced sort options likemissing,mode,unmapped_type, etc.The main driver behind this change is the multiple-index search feature that was added with JAY-676 (#35). When searching across multiple indexes, it's important to handle cases where a field might be missing in some indexes. By allowing sort options, users can now specify how to handle this scenario.
Without this possibility queries will just fail if a field is missing in one of the indexes.