[mdns] Support for fuzzing browses#1067
Open
david-cermak wants to merge 8 commits into
Open
Conversation
also updates browse PTR model to support TTL=0/removal
david-cermak
force-pushed
the
feat/mdns_fuzz_browse
branch
4 times, most recently
from
952585f to
f5a0dc6
Compare
Packets with 11 bytes passed the old length check but caused a read past the RX buffer when loading the additional RR count field.
browse_init stores service and proto with strlen+1 allocations, but packet parsing copied MDNS_NAME_BUF_LEN bytes into browse snapshots.
Free browse sync pending lists on packet parse errors, tear down async searches detached by search_finish in the host unit test, and replace reassigned browse hostnames without leaking the old allocation.
Key-only TXT records leave value NULL; comparing them with memcmp triggered UBSan when fuzzed browse responses updated existing results.
david-cermak
force-pushed
the
feat/mdns_fuzz_browse
branch
from
f5a0dc6 to
acc8fa9
Compare
david-cermak
force-pushed
the
feat/mdns_fuzz_browse
branch
from
acc8fa9 to
c5ac023
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1066