Test project board #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espinu
commented
Mar 5, 2021
|
|
||
| Background: | ||
|
|
||
| What has been done: |
Open
espinu
commented
Mar 5, 2021
| func foo() -> Int { | ||
| _ = foo1() | ||
| let bla = "unused variable" | ||
| return param1+param2 |
Owner
Author
There was a problem hiding this comment.
Operators should be surrounded by a single whitespace when they are being used.operator_usage_whitespace Foo.swift:17 |
espinu
commented
Mar 5, 2021
| let bla = "unused variable" | ||
| return param1+param2 | ||
| } | ||
| func foo1() -> Int { |
Owner
Author
There was a problem hiding this comment.
Function should have complexity 5 or less: currently complexity equals 12cyclomatic_complexity Foo.swift:19 |
espinu
commented
Mar 5, 2021
| if param1 == 11 { | ||
|
|
||
| } | ||
| }else if param1 == 11 { |
Owner
Author
There was a problem hiding this comment.
Else and catch should be on the same line, one space after the previous declaration.statement_position Foo.swift:31 |
espinu
commented
Mar 5, 2021
|
|
||
| } | ||
| } | ||
| }else if param1 == 11 { |
Owner
Author
There was a problem hiding this comment.
Else and catch should be on the same line, one space after the previous declaration.statement_position Foo.swift:36 |
Owner
Author
espinu
commented
Mar 5, 2021
| } else if param1 == 11 { | ||
|
|
||
| } | ||
| return param1+param2 |
Owner
Author
There was a problem hiding this comment.
Operators should be surrounded by a single whitespace when they are being used.operator_usage_whitespace Foo.swift:46 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issues #2