refactor(cli): redo... everything, should be backwards compatible.#1
Open
crankynetmaam wants to merge 17 commits into
Open
refactor(cli): redo... everything, should be backwards compatible.#1crankynetmaam wants to merge 17 commits into
crankynetmaam wants to merge 17 commits into
Conversation
…(a subset of list_queue)
…es, retry failed ones modularize the code a bit as it was growing to be confusing with the layout we had. this helps us handle the different ways to handle messages as well. we dont want to delete from PEL as thats the messages redis hasnt seen yet. we should process those. we can delete them entirely from the stream if they are successful. we ack the ones that dont get a 201 from SCRAM. this lets us then go back and loop the acked messages and retry, without impacting the new PEL messages
…confusing as root and clean up error_message vars
…don't have to pass the same one around all the time. Hopefully this works how I think it does.
… us avoid repeating this code in multiple places.
…the new failed_queue as well
…aner and modular.
…en't successfully blocked. Also set up logic for retries from this stream. Note: A couple other stragglers I forgot..
…d_messages fix(memory_leak): By not removing any messages we were seeing memory leaks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: Doc updates