ci(tests): Cleanup workflow runs#231
Conversation
…oml w/ uv workspaces
…ings/uv-workspaces-django
…ings/uv-workspaces-django
Co-authored-by: Copilot <copilot@github.com>
|
Scheduler Coverage
Minimum allowed coverage is Generated by 🐒 cobertura-action against d5978e3 |
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…net-security/SCRAM into topic/chriscummings/cleanup-test-runs
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
|
Scripts Coverage
Minimum allowed coverage is Generated by 🐒 cobertura-action against d5978e3 |
|
Django Coverage
Minimum allowed coverage is Generated by 🐒 cobertura-action against d5978e3 |
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
|
Translator Coverage
Minimum allowed coverage is Generated by 🐒 cobertura-action against d5978e3 |
|
I see the 4 neutral checks that say "Run Scheduler Tests" but then they are actually for different coverages. i cant quite figure out why, but it would be nice to see that cleaned up. |
This was bothering me too. Unfortunately it seems to be a quirk of cobertura/github where it picks up the "check_suite_id" of the first check that passes and then considers that the parent check... We could rename all of the CI job names that upload coverage to just be "coverage" then whichever runs first that will be the parent name but I'd rather not. The right info is there now, it's just hidden a bit. What we could do is just move to a different approach for those coverage messages (or get rid of them, but I like having them on the PR) |
samoehlert
left a comment
There was a problem hiding this comment.
This will make CI so much more useful and less annoying. Thanks!
This PR cleans up our workflows to run on a per-app basis and upload things in the same manner. It also renames all of the make targets to
test-applicationto get ride of behave vs pytest and all the confusion there. Now it just runs the tests for one of the applications. You can still call pytest and behave but the targets are all simplified. I also added a (neutral) type-check workflow.. It fails all the time (so we ignore that) but I want to run type checking in the future so I figure this gets us to where it's ready to remove || true once we fix type checking errors in the code base.Finally, this adds a make target
ci-act(actneeds to be installed via brew locally) which allows you to test GH actions locally. Works pretty well.I also restructured the Makefile. It was way too out of order and the names didn't make sense anymore as we've scaled things. Changes are:
Renamed:
Removed:
Added/Significantly modified:
behave-translator. This wasn't added, but now it has coverage, doesn't just run tests.
test-django. runs all tests for django (pytest-django + behave-django + integration-django)
test-translator: builds/runs stack + runs behave-translator
test: runs all four test-* targets (so in theory ALL test types)
ci-test: runs all CI workflows locally via act (old ci-test didn't mirror CI at all).
behave-translator-feature. Allows you to run just one behave feature for translator.
Should close #200 and #219.