test: add test cases for AST node expansion and interactions#398
Open
lumirlumir wants to merge 17 commits into
Open
test: add test cases for AST node expansion and interactions#398lumirlumir wants to merge 17 commits into
lumirlumir wants to merge 17 commits into
Conversation
✅ Deploy Preview for eslint-code-explorer ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
1 task
lumirlumir
changed the title
lumirlumir
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Pull request overview
Adds end-to-end Playwright tests for AST node expansion across multiple language parser options (JavaScript, JSON, Markdown, CSS, HTML), structured into test.describe blocks for clarity.
Changes:
- Adds an
AST node expansiondescribe block covering JavaScript source types, ECMAScript version, and JSX. - Adds JSON tests for JSON/JSONC/JSON5 modes and
Allow Trailing Commasoption. - Adds Markdown (CommonMark/GFM, frontmatter variants, math), CSS (tolerant parsing), and HTML (template engine syntax, front matter) tests.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request?
This PR adds AST node expansion tests for various parser options, such as Markdown frontmatter and math, as well as the JSON
allowTrailingCommasoption.Since these end-to-end test cases cover the full range of AST interactions across different languages, the amount of code added is a bit large. However, that was the original purpose of #64 (comment), so I think it’s worth adding.
What changes did you make? (Give an overview)
Added test cases for:
Also, I’ve divided the section using
test.describeto make it clearer how the tests are partitioned and structured.Related Issues
N/A
Is there anything you'd like reviewers to focus on?
N/A