Open
Conversation
✅ Deploy Preview for eslint-code-explorer ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
amareshsm
approved these changes
Mar 29, 2026
Member
amareshsm
left a comment
There was a problem hiding this comment.
LGTM. I’ll keep it open for another day in case anyone else wants to review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request?
This PR fixes explorer state persistence when the edited code contains Unicode characters. Previously, writing the shareable URL hash could throw
InvalidCharacterErrorbecause the app usedbtoa(...)on a string containing characters outside the Latin1 range.Steps to reproduce
What changes did you make? (Give an overview)
Related Issues
I ran into this while working on eslint/markdown#640, where I noticed that emojis in the editor were no longer present after a reload.
Is there anything you'd like reviewers to focus on?