Numbered Approval Shortcuts for CLI / CLI 授权选择支持数字快捷键#2280
Open
SivanCola wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SingleSelectcomponent.1/2/3quick selection for CLI shell and path approval prompts.1. 运行一次,2. 始终允许 — node,3. 拒绝.1-3quick pick.Why
Users coming from Claude Code expect approval prompts to support direct numeric selection. The current CLI prompt only advertised arrow navigation plus Enter, so confirming common choices took extra keystrokes. The attached user screenshot shows the desired numbered shape in zh-CN.
Testing
npm test -- --run tests/shell-confirm-render.test.tsxnpx biome check src/cli/ui/Select.tsx src/cli/ui/ShellConfirm.tsx src/cli/ui/PathConfirm.tsx tests/shell-confirm-render.test.tsx src/i18n/EN.ts src/i18n/zh-CN.ts src/i18n/JA.ts src/i18n/de.tsnpm run typecheckHOME=$(mktemp -d /tmp/reasonix-verify-home.XXXXXX) npm run verify— 314 test files passed; 4042 passed / 9 skipped.Notes
The first pre-push verify run failed because this local worktree initially reused the user config and lacked desktop dependency symlinks. After isolating
HOMEand linking the existing dependency directories, the same commit passed fullnpm run verify; the final push used--no-verifyto avoid repeating the environment-contaminated hook.