Improve compatibility with + add test for DOMException#3
Open
lionel-rowe wants to merge 3 commits intoes-shims:mainfrom
Open
Improve compatibility with + add test for DOMException#3lionel-rowe wants to merge 3 commits intoes-shims:mainfrom
lionel-rowe wants to merge 3 commits intoes-shims:mainfrom
Conversation
lionel-rowe
commented
Nov 13, 2024
lionel-rowe
force-pushed
the
domexception
branch
from
3312706 to
4b6c74b
Compare
lionel-rowe
force-pushed
the
domexception
branch
from
4b6c74b to
fe4d3cf
Compare
ljharb
reviewed
Nov 13, 2024
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
ftr, this polyfill has been tested in every Firefox, Chrome, Edge, Safari, and Opera version Browserstack has listed, so this change will require similar rigor to land.
ljharb
requested changes
Nov 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2