fix: Swap ModelSupportsVaneHorizontal and ModelSupportsVaneVertical#4
fix: Swap ModelSupportsVaneHorizontal and ModelSupportsVaneVertical#4erwindouna merged 2 commits intoerwindouna:masterfrom Sander0542:fix/swap-model-supports-vane
Conversation
There was a problem hiding this comment.
Maybe it would be interesting to add a comment before each of these changes saying something like "Note that the horizontal and vertical fields are swapped in the device information returned by the MELCloud API so the next line is actually right", so that nobody reads the code in the future and thinks "This seems wrong, I'll fix it".
Appart from that, the change itself looks fine to me and should fix an issue that has been reported by MANY users of home assistant with MELCloud ac systems that only support vertical vanes.
|
Thanks for the suggestion @antlarr. I just pushed a commit with comments in the code |
|
@erwindouna could you have a look at this PR, please? |
|
Thanks for submitting the PR, @Sander0542! Sorry that it got overlooked. I'll merge it and try to make a new releases anytime soon! :) |
Thank you for merging! |
Proposed Changes
Swap the
ModelSupportsVaneHorizontalandModelSupportsVaneVerticalflags in the positions propertiesRelated Issues
Closes #3