Skip to content

Expose execution_type_desc filter to CLI and MCP#325

Merged
erikdarlingdata merged 1 commit into
devfrom
feature/cli-mcp-execution-type-filter
May 10, 2026
Merged

Expose execution_type_desc filter to CLI and MCP#325
erikdarlingdata merged 1 commit into
devfrom
feature/cli-mcp-execution-type-filter

Conversation

@erikdarlingdata
Copy link
Copy Markdown
Owner

Summary

  • Adds --execution-type to the CLI query-store command.
  • Adds execution_type parameter to the get_query_store_top MCP tool.
  • Accepts regular, aborted, exception, failed (= aborted + exception), any (case-insensitive).
  • Parsing logic centralized in QueryStoreFilter.ParseExecutionType.
  • Mirrors the desktop UI filter added in Allow filter by "execution_type_desc" on Query Store screen #321 — was flagged as a follow-up in that review.

Test plan

  • dotnet build PlanViewer.sln — 0 warnings, 0 errors.
  • planview query-store --help shows --execution-type with the right description.
  • Run against a real server with --execution-type failed and verify only aborted/exception plans return.
  • Call get_query_store_top via MCP with execution_type: "failed" and verify the filter applies.

Adds --execution-type to the CLI query-store command and execution_type
to the get_query_store_top MCP tool, accepting regular/aborted/exception/
failed (= aborted + exception). Mirrors the desktop UI filter added in
#321. Parsing logic is centralized in QueryStoreFilter.ParseExecutionType.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@erikdarlingdata erikdarlingdata force-pushed the feature/cli-mcp-execution-type-filter branch from e830aed to 78339bd Compare May 10, 2026 19:56
@erikdarlingdata erikdarlingdata merged commit ee40047 into dev May 10, 2026
2 checks passed
@erikdarlingdata erikdarlingdata deleted the feature/cli-mcp-execution-type-filter branch May 10, 2026 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant