Skip to content

Remove dead FetchHistoryAsync and FetchHistoryByHashAsync #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikdarlingdata merged 1 commit into from
May 10, 2026
+0 −207
Merged

Remove dead FetchHistoryAsync and FetchHistoryByHashAsync #324

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
207 changes: 0 additions & 207 deletions src/PlanViewer.Core/Services/QueryStoreService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,213 +373,6 @@ ELSE N''
return plans;
}

public static async Task<List<QueryStoreHistoryRow>> FetchHistoryAsync(
string connectionString, long queryId, int hoursBack = 24,
CancellationToken ct = default)
{
const string sql = @"
SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;

SELECT
p.plan_id,
CONVERT(varchar(18), MAX(p.query_plan_hash), 1),
rsi.start_time,
SUM(rs.count_executions),
CASE WHEN SUM(rs.count_executions) > 0
THEN SUM(rs.avg_duration * rs.count_executions) / SUM(rs.count_executions) / 1000.0
ELSE 0 END,
CASE WHEN SUM(rs.count_executions) > 0
THEN SUM(rs.avg_cpu_time * rs.count_executions) / SUM(rs.count_executions) / 1000.0
ELSE 0 END,
CASE WHEN SUM(rs.count_executions) > 0
THEN SUM(rs.avg_logical_io_reads * rs.count_executions) / SUM(rs.count_executions)
ELSE 0 END,
CASE WHEN SUM(rs.count_executions) > 0
THEN SUM(rs.avg_logical_io_writes * rs.count_executions) / SUM(rs.count_executions)
ELSE 0 END,
CASE WHEN SUM(rs.count_executions) > 0
THEN SUM(rs.avg_physical_io_reads * rs.count_executions) / SUM(rs.count_executions)
ELSE 0 END,
CASE WHEN SUM(rs.count_executions) > 0
THEN SUM(rs.avg_query_max_used_memory * rs.count_executions) / SUM(rs.count_executions) * 8.0 / 1024.0
ELSE 0 END,
CASE WHEN SUM(rs.count_executions) > 0
THEN SUM(rs.avg_rowcount * rs.count_executions) / SUM(rs.count_executions)
ELSE 0 END,
SUM(rs.avg_duration * rs.count_executions) / 1000.0,
SUM(rs.avg_cpu_time * rs.count_executions) / 1000.0,
SUM(rs.avg_logical_io_reads * rs.count_executions),
SUM(rs.avg_logical_io_writes * rs.count_executions),
SUM(rs.avg_physical_io_reads * rs.count_executions),
MIN(rs.min_dop),
MAX(rs.max_dop),
MAX(rs.last_execution_time),
MAX(rs.execution_type_desc)
FROM sys.query_store_runtime_stats rs
JOIN sys.query_store_runtime_stats_interval rsi
ON rs.runtime_stats_interval_id = rsi.runtime_stats_interval_id
JOIN sys.query_store_plan p
ON rs.plan_id = p.plan_id
WHERE p.query_id = @queryId
AND rsi.start_time >= DATEADD(HOUR, -@hoursBack, GETUTCDATE())
AND rs.first_execution_time >= DATEADD(HOUR, -@hoursBack, GETUTCDATE()) --performance: filter runtime_stats by time directly
GROUP BY p.plan_id, rsi.start_time
ORDER BY rsi.start_time, p.plan_id;";

var rows = new List<QueryStoreHistoryRow>();

await using var conn = new SqlConnection(connectionString);
await conn.OpenAsync(ct);
await using var cmd = new SqlCommand(sql, conn) { CommandTimeout = 120 };
cmd.Parameters.Add(new SqlParameter("@queryId", queryId));
cmd.Parameters.Add(new SqlParameter("@hoursBack", hoursBack));
await using var reader = await cmd.ExecuteReaderAsync(ct);

while (await reader.ReadAsync(ct))
{
rows.Add(new QueryStoreHistoryRow
{
PlanId = reader.GetInt64(0),
QueryPlanHash = reader.IsDBNull(1) ? "" : reader.GetString(1),
IntervalStartUtc = ((DateTimeOffset)reader.GetValue(2)).UtcDateTime,
CountExecutions = reader.GetInt64(3),
AvgDurationMs = reader.GetDouble(4),
AvgCpuMs = reader.GetDouble(5),
AvgLogicalReads = reader.GetDouble(6),
AvgLogicalWrites = reader.GetDouble(7),
AvgPhysicalReads = reader.GetDouble(8),
AvgMemoryMb = reader.GetDouble(9),
AvgRowcount = reader.GetDouble(10),
TotalDurationMs = reader.GetDouble(11),
TotalCpuMs = reader.GetDouble(12),
TotalLogicalReads = reader.GetDouble(13),
TotalLogicalWrites = reader.GetDouble(14),
TotalPhysicalReads = reader.GetDouble(15),
MinDop = (int)reader.GetInt64(16),
MaxDop = (int)reader.GetInt64(17),
LastExecutionUtc = reader.IsDBNull(18) ? null : ((DateTimeOffset)reader.GetValue(18)).UtcDateTime,
ExecutionTypeDesc = reader.IsDBNull(19) ? "" : reader.GetString(19),
});
}

return rows;
}

/// <summary>
/// Fetches interval-level history rows for all queries sharing the given query_hash.
/// When <paramref name="startUtc"/>/<paramref name="endUtc"/> are provided they define the
/// time window (slicer range); otherwise falls back to <paramref name="hoursBack"/>.
/// </summary>
public static async Task<List<QueryStoreHistoryRow>> FetchHistoryByHashAsync(
string connectionString, string queryHash, int hoursBack = 24,
CancellationToken ct = default,
DateTime? startUtc = null, DateTime? endUtc = null)
{
var parameters = new List<SqlParameter>();
parameters.Add(new SqlParameter("@queryHash", queryHash.Trim()));

string timeFilter;
if (startUtc.HasValue && endUtc.HasValue)
{
timeFilter = "AND rsi.start_time >= @rangeStart AND rsi.start_time < @rangeEnd";
parameters.Add(new SqlParameter("@rangeStart", startUtc.Value));
parameters.Add(new SqlParameter("@rangeEnd", endUtc.Value));
}
else
{
timeFilter = "AND rsi.start_time >= DATEADD(HOUR, -@hoursBack, GETUTCDATE())";
parameters.Add(new SqlParameter("@hoursBack", hoursBack));
}

var sql = $@"
SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;

SELECT
p.plan_id,
CONVERT(varchar(18), MAX(p.query_plan_hash), 1),
rsi.start_time,
SUM(rs.count_executions),
CASE WHEN SUM(rs.count_executions) > 0
THEN SUM(rs.avg_duration * rs.count_executions) / SUM(rs.count_executions) / 1000.0
ELSE 0 END,
CASE WHEN SUM(rs.count_executions) > 0
THEN SUM(rs.avg_cpu_time * rs.count_executions) / SUM(rs.count_executions) / 1000.0
ELSE 0 END,
CASE WHEN SUM(rs.count_executions) > 0
THEN SUM(rs.avg_logical_io_reads * rs.count_executions) / SUM(rs.count_executions)
ELSE 0 END,
CASE WHEN SUM(rs.count_executions) > 0
THEN SUM(rs.avg_logical_io_writes * rs.count_executions) / SUM(rs.count_executions)
ELSE 0 END,
CASE WHEN SUM(rs.count_executions) > 0
THEN SUM(rs.avg_physical_io_reads * rs.count_executions) / SUM(rs.count_executions)
ELSE 0 END,
CASE WHEN SUM(rs.count_executions) > 0
THEN SUM(rs.avg_query_max_used_memory * rs.count_executions) / SUM(rs.count_executions) * 8.0 / 1024.0
ELSE 0 END,
CASE WHEN SUM(rs.count_executions) > 0
THEN SUM(rs.avg_rowcount * rs.count_executions) / SUM(rs.count_executions)
ELSE 0 END,
SUM(rs.avg_duration * rs.count_executions) / 1000.0,
SUM(rs.avg_cpu_time * rs.count_executions) / 1000.0,
SUM(rs.avg_logical_io_reads * rs.count_executions),
SUM(rs.avg_logical_io_writes * rs.count_executions),
SUM(rs.avg_physical_io_reads * rs.count_executions),
MIN(rs.min_dop),
MAX(rs.max_dop),
MAX(rs.last_execution_time),
MAX(rs.execution_type_desc)
FROM sys.query_store_runtime_stats rs
JOIN sys.query_store_runtime_stats_interval rsi
ON rs.runtime_stats_interval_id = rsi.runtime_stats_interval_id
JOIN sys.query_store_plan p
ON rs.plan_id = p.plan_id
JOIN sys.query_store_query q
ON p.query_id = q.query_id
WHERE q.query_hash = CONVERT(binary(8), @queryHash, 1)
{timeFilter}
GROUP BY p.plan_id, rsi.start_time
ORDER BY rsi.start_time, p.plan_id;";

var rows = new List<QueryStoreHistoryRow>();

await using var conn = new SqlConnection(connectionString);
await conn.OpenAsync(ct);
await using var cmd = new SqlCommand(sql, conn) { CommandTimeout = 120 };
foreach (var p in parameters)
cmd.Parameters.Add(p);
await using var reader = await cmd.ExecuteReaderAsync(ct);

while (await reader.ReadAsync(ct))
{
rows.Add(new QueryStoreHistoryRow
{
PlanId = reader.GetInt64(0),
QueryPlanHash = reader.IsDBNull(1) ? "" : reader.GetString(1),
IntervalStartUtc = ((DateTimeOffset)reader.GetValue(2)).UtcDateTime,
CountExecutions = reader.GetInt64(3),
AvgDurationMs = reader.GetDouble(4),
AvgCpuMs = reader.GetDouble(5),
AvgLogicalReads = reader.GetDouble(6),
AvgLogicalWrites = reader.GetDouble(7),
AvgPhysicalReads = reader.GetDouble(8),
AvgMemoryMb = reader.GetDouble(9),
AvgRowcount = reader.GetDouble(10),
TotalDurationMs = reader.GetDouble(11),
TotalCpuMs = reader.GetDouble(12),
TotalLogicalReads = reader.GetDouble(13),
TotalLogicalWrites = reader.GetDouble(14),
TotalPhysicalReads = reader.GetDouble(15),
MinDop = (int)reader.GetInt64(16),
MaxDop = (int)reader.GetInt64(17),
LastExecutionUtc = reader.IsDBNull(18) ? null : ((DateTimeOffset)reader.GetValue(18)).UtcDateTime,
ExecutionTypeDesc = reader.IsDBNull(19) ? "" : reader.GetString(19),
});
}

return rows;
}

/// <summary>
/// Fetches interval-level history rows for all queries sharing the given query_hash,
/// grouped by query_plan_hash and interval start.
Expand Down