Fix #938 — preserve mute rules across size-triggered DB reset#941
Merged
Conversation
When monitor.duckdb exceeds 512 MB, ArchiveAllAndResetAsync deletes the file and reinitializes empty tables. config_mute_rules was not in ArchivableTables, so all mute rules — including permanent rules with expires_at_utc = NULL — were silently lost. Export config_mute_rules and dismissed_archive_alerts to a temp Parquet dir before the reset and re-import after. Parquet roundtrip keeps this schema-agnostic. On restore failure, the temp dir is retained for manual recovery. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ArchiveAllAndResetAsync(size-triggered DB reset at 512 MB) deletesmonitor.duckdband reinitializes empty tables.config_mute_ruleswas not inArchivableTables, so all mute rules — including permanent rules withexpires_at_utc = NULL— were silently lost.config_mute_rulesanddismissed_archive_alertsto a temp Parquet dir before the reset and re-import after. Parquet roundtrip keeps this schema-agnostic. On restore failure, the temp dir is retained for manual recovery.Fixes #938
Test plan
MuteRulesSurviveResetTests.PermanentMuteRule_SurvivesArchiveAllAndReset(the bug case)MuteRulesSurviveResetTests.ExpiringMuteRule_SurvivesArchiveAllAndResetMuteRulesSurviveResetTests.EmptyMuteRulesTable_DoesNotBreakResetLite.Testssuite passes (260/260)🤖 Generated with Claude Code