Skip to content

Conversation

@pmcnano
Copy link

@pmcnano pmcnano commented Aug 12, 2023

August 12th 2023

August 12th 2023
Copy link
Owner

@ericcj ericcj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you could you please include the changelog update to go along with it, e.g. what model versions changed and what breaking changes do they include (or a link to amazon's changelog detailing that) like i did for https://github.com/ericcj/amz_sp_api/releases/tag/v1.0.0

also this was generated with a later swagger please confirm nothing about its generated client/configuration internal API changed since we are extending non-public parts of it here. lib/api_client.rb and lib/api_error.rb are copied from the generated code (aside from the namespace and the const_get) so if swagger has changed them we should update them as well, e.g. you can see it with "diff lib/api_client.rb lib/orders-api-model/api_client.rb"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants