Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .claude/CLAUDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,34 @@ microservice system using .NET 10, NServiceBus, and a React frontend.
| Frontend | Vite + React + TypeScript |
| Package Mgmt | Central package management (Directory.Packages.props) |

## Domain Entity & Aggregate Construction — MANDATORY

**NEVER use parameterized constructors on domain entities, aggregate roots, or value objects.** This is an absolute rule with zero exceptions.

- All domain entities, aggregates, and aggregate roots MUST use the **implicit default (parameterless) constructor + object initializer syntax**
- Properties set only at creation time use `init` setters
- Properties modified by domain methods use `private set`
- Status properties use `private set` — their default enum value (position 0) represents the initial state
- Variance/computed properties that are set once at creation use `init`
- EF Core materializes entities using the parameterless constructor and sets properties via backing fields

**Correct:**
```csharp
var entity = new MyEntity
{
Id = Guid.NewGuid(),
Name = "example",
CreatedDate = DateTime.Now,
};
```

**WRONG — never do this:**
```csharp
var entity = new MyEntity(Guid.NewGuid(), "example", DateTime.Now);
```

This applies everywhere: handlers, seeders, tests, helpers — every call site that creates a domain object.

## Coding Standards

- All code MUST pass StyleCop analysis using the ruleset at `src/StyleCopAnalyzers.ruleset`
Expand Down
1 change: 1 addition & 0 deletions .claude/agents/saga-scaffolder.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ For the NServiceBus MS SQL Server Scripts, the latest documentation is always av
- Handler file: `src/{TargetService}/MidstreamHub.{TargetService}.Application/Handlers/{HandlerName}.cs`
- Handler should implement `IHandleMessages<TCommand>`
- After processing, the handler should publish the corresponding completion event
- **When handlers create domain entities, use object initializer syntax (NEVER parameterized constructors)**

### 7. Verify build
- Run `dotnet build src/MidstreamHub.sln` to verify everything compiles
Expand Down
8 changes: 7 additions & 1 deletion .claude/agents/service-scaffolder.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,16 @@ for MidstreamHub. You receive a service name and aggregate root description.
- Key entity descriptions
- Database schema name

## CRITICAL: No Parameterized Constructors

**NEVER create parameterized constructors on domain entities, aggregate roots, or value objects.**

All domain objects MUST use the implicit default (parameterless) constructor + object initializer syntax. Use `init` setters for creation-only properties and `private set` for properties modified by domain methods. This applies to the Domain layer entities AND every call site (handlers, seeders, tests).

## Steps
1. Create all project folders following the Contracts service structure exactly
2. Create .csproj files with correct project references and central package versions
3. Create the Domain layer: aggregate root, entities, value objects, repository interface
3. Create the Domain layer: aggregate root, entities, value objects, repository interface — **NO parameterized constructors; use `init` / `private set` property pattern**
4. Create the Application layer: MediatR commands/queries/handlers, FluentValidation validators, DTOs
5. Create the Infrastructure layer: EF Core DbContext, entity configs, repository impl, Autofac module
6. Create the Api layer: Minimal API endpoints, Program.cs with NServiceBus + Autofac, Autofac root module
Expand Down
1 change: 1 addition & 0 deletions .claude/skills/clean-architecture.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ When creating or modifying service layers, follow this dependency rule:
- Aggregate roots, entities, value objects, domain events
- No framework dependencies (no EF Core, no MediatR)
- Rich domain model with behavior, not anemic
- **NEVER use parameterized constructors** on entities, aggregates, or value objects — use `init` setters + object initializer syntax. `private set` for properties modified by domain methods.

### Application
- MediatR command/query handlers
Expand Down
1 change: 1 addition & 0 deletions .claude/skills/cqrs-mediatr.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
- One handler per command in the Application layer
- Validators in the same folder as the command
- Commands mutate state; always return a result indicating success/failure
- When handlers create domain entities, use **object initializer syntax** (NEVER parameterized constructors)

## Queries
- Inherit from `IRequest<TResponse>`
Expand Down
52 changes: 47 additions & 5 deletions .claude/skills/ddd-patterns.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,50 @@
# DDD Patterns Skill

## CRITICAL: No Parameterized Constructors — EVER

**NEVER create parameterized constructors on domain entities, aggregate roots, or value objects.**

All domain objects MUST be constructed using the **implicit default (parameterless) constructor + object initializer syntax**. No exceptions. No "just this once." No "for convenience." NEVER.

### Property setter strategy:
- `init` — Properties set at creation time, never modified after. Allows object initializer syntax but prevents later mutation.
- `private set` — Properties modified by domain methods (Status, RejectionReason, etc.). EF Core can set these via backing fields during materialization.

### Why:
EF Core's constructor binding logic selects parameterized constructors over private parameterless ones during entity materialization. When a parameterized constructor hardcodes an initial value (e.g., `Status = Draft`), EF Core does NOT overwrite it with the actual DB value. This causes APIs to silently return wrong data. Object initializer syntax with `init`/`private set` avoids this entirely.

### Correct:
```csharp
public class Contract : AggregateRoot<Guid>
{
public string ContractNumber { get; init; } = string.Empty;
public Guid CounterpartyId { get; init; }
public ContractStatus Status { get; private set; } // default(ContractStatus) = Draft
}

// Creation:
var contract = new Contract
{
Id = Guid.NewGuid(),
ContractNumber = "CTR-2025-001",
CounterpartyId = counterpartyId,
};
```

### WRONG — never do this:
```csharp
public class Contract : AggregateRoot<Guid>
{
public Contract(Guid id, string contractNumber, Guid counterpartyId)
{
Id = id;
ContractNumber = contractNumber;
CounterpartyId = counterpartyId;
Status = ContractStatus.Draft; // BUG: EF Core won't overwrite this
}
}
```

## Aggregate Root
- Single entry point for all modifications to the aggregate
- Enforce invariants in the aggregate root's methods
Expand All @@ -10,16 +55,13 @@
- Use records in C# for value objects
- Value objects from OTHER SORs are hydrated via API calls, never DB joins
- Cache hydrated value objects appropriately
- Value objects used in EF Core entity configs (especially when some properties are `.Ignore()`d) need a **private parameterless constructor** for EF materialization. Place it AFTER the public constructor (StyleCop SA1202).
```csharp
public MyValueObject(string a, string b) { A = a; B = b; }
private MyValueObject() { A = null!; B = null!; }
```
- Value objects used in EF Core entity configs need `init` setters, NOT parameterized constructors

## Entities
- Have identity (Id property)
- Belong to an aggregate; only accessible through the aggregate root
- Mutable, but changes go through aggregate root methods
- NEVER use parameterized constructors — use object initializer syntax

## Repository Pattern
- One repository per aggregate root
Expand Down
1 change: 1 addition & 0 deletions .claude/skills/tdd-nunit.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
- Arrange / Act / Assert pattern
- One assert per test (prefer)
- Descriptive test names: `MethodName_Scenario_ExpectedResult`
- **Domain entity creation in tests MUST use object initializer syntax** (NEVER parameterized constructors). Test helper methods like `CreateTestNomination()` must follow this rule too.

## Test Categories
- `[Category("Unit")]` for pure logic tests
Expand Down
2 changes: 2 additions & 0 deletions .serena/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
/cache
/project.local.yml
152 changes: 152 additions & 0 deletions .serena/project.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,152 @@
# the name by which the project can be referenced within Serena
project_name: "claude-code-demo"


# list of languages for which language servers are started; choose from:
# al bash clojure cpp csharp
# csharp_omnisharp dart elixir elm erlang
# fortran fsharp go groovy haskell
# java julia kotlin lua markdown
# matlab nix pascal perl php
# php_phpactor powershell python python_jedi r
# rego ruby ruby_solargraph rust scala
# swift terraform toml typescript typescript_vts
# vue yaml zig
# (This list may be outdated. For the current list, see values of Language enum here:
# https://github.com/oraios/serena/blob/main/src/solidlsp/ls_config.py
# For some languages, there are alternative language servers, e.g. csharp_omnisharp, ruby_solargraph.)
# Note:
# - For C, use cpp
# - For JavaScript, use typescript
# - For Free Pascal/Lazarus, use pascal
# Special requirements:
# Some languages require additional setup/installations.
# See here for details: https://oraios.github.io/serena/01-about/020_programming-languages.html#language-servers
# When using multiple languages, the first language server that supports a given file will be used for that file.
# The first language is the default language and the respective language server will be used as a fallback.
# Note that when using the JetBrains backend, language servers are not used and this list is correspondingly ignored.
languages:
- csharp

# the encoding used by text files in the project
# For a list of possible encodings, see https://docs.python.org/3.11/library/codecs.html#standard-encodings
encoding: "utf-8"

# line ending convention to use when writing source files.
# Possible values: unset (use global setting), "lf", "crlf", or "native" (platform default)
# This does not affect Serena's own files (e.g. memories and configuration files), which always use native line endings.
line_ending:

# The language backend to use for this project.
# If not set, the global setting from serena_config.yml is used.
# Valid values: LSP, JetBrains
# Note: the backend is fixed at startup. If a project with a different backend
# is activated post-init, an error will be returned.
language_backend:

# whether to use project's .gitignore files to ignore files
ignore_all_files_in_gitignore: true

# list of additional paths to ignore in this project.
# Same syntax as gitignore, so you can use * and **.
# Note: global ignored_paths from serena_config.yml are also applied additively.
ignored_paths: []

# whether the project is in read-only mode
# If set to true, all editing tools will be disabled and attempts to use them will result in an error
# Added on 2025-04-18
read_only: false

# list of tool names to exclude.
# This extends the existing exclusions (e.g. from the global configuration)
#
# Below is the complete list of tools for convenience.
# To make sure you have the latest list of tools, and to view their descriptions,
# execute `uv run scripts/print_tool_overview.py`.
#
# * `activate_project`: Activates a project by name.
# * `check_onboarding_performed`: Checks whether project onboarding was already performed.
# * `create_text_file`: Creates/overwrites a file in the project directory.
# * `delete_lines`: Deletes a range of lines within a file.
# * `delete_memory`: Deletes a memory from Serena's project-specific memory store.
# * `execute_shell_command`: Executes a shell command.
# * `find_referencing_code_snippets`: Finds code snippets in which the symbol at the given location is referenced.
# * `find_referencing_symbols`: Finds symbols that reference the symbol at the given location (optionally filtered by type).
# * `find_symbol`: Performs a global (or local) search for symbols with/containing a given name/substring (optionally filtered by type).
# * `get_current_config`: Prints the current configuration of the agent, including the active and available projects, tools, contexts, and modes.
# * `get_symbols_overview`: Gets an overview of the top-level symbols defined in a given file.
# * `initial_instructions`: Gets the initial instructions for the current project.
# Should only be used in settings where the system prompt cannot be set,
# e.g. in clients you have no control over, like Claude Desktop.
# * `insert_after_symbol`: Inserts content after the end of the definition of a given symbol.
# * `insert_at_line`: Inserts content at a given line in a file.
# * `insert_before_symbol`: Inserts content before the beginning of the definition of a given symbol.
# * `list_dir`: Lists files and directories in the given directory (optionally with recursion).
# * `list_memories`: Lists memories in Serena's project-specific memory store.
# * `onboarding`: Performs onboarding (identifying the project structure and essential tasks, e.g. for testing or building).
# * `prepare_for_new_conversation`: Provides instructions for preparing for a new conversation (in order to continue with the necessary context).
# * `read_file`: Reads a file within the project directory.
# * `read_memory`: Reads the memory with the given name from Serena's project-specific memory store.
# * `remove_project`: Removes a project from the Serena configuration.
# * `replace_lines`: Replaces a range of lines within a file with new content.
# * `replace_symbol_body`: Replaces the full definition of a symbol.
# * `restart_language_server`: Restarts the language server, may be necessary when edits not through Serena happen.
# * `search_for_pattern`: Performs a search for a pattern in the project.
# * `summarize_changes`: Provides instructions for summarizing the changes made to the codebase.
# * `switch_modes`: Activates modes by providing a list of their names
# * `think_about_collected_information`: Thinking tool for pondering the completeness of collected information.
# * `think_about_task_adherence`: Thinking tool for determining whether the agent is still on track with the current task.
# * `think_about_whether_you_are_done`: Thinking tool for determining whether the task is truly completed.
# * `write_memory`: Writes a named memory (for future reference) to Serena's project-specific memory store.
excluded_tools: []

# list of tools to include that would otherwise be disabled (particularly optional tools that are disabled by default).
# This extends the existing inclusions (e.g. from the global configuration).
included_optional_tools: []

# fixed set of tools to use as the base tool set (if non-empty), replacing Serena's default set of tools.
# This cannot be combined with non-empty excluded_tools or included_optional_tools.
fixed_tools: []

# list of mode names to that are always to be included in the set of active modes
# The full set of modes to be activated is base_modes + default_modes.
# If the setting is undefined, the base_modes from the global configuration (serena_config.yml) apply.
# Otherwise, this setting overrides the global configuration.
# Set this to [] to disable base modes for this project.
# Set this to a list of mode names to always include the respective modes for this project.
base_modes:

# list of mode names that are to be activated by default.
# The full set of modes to be activated is base_modes + default_modes.
# If the setting is undefined, the default_modes from the global configuration (serena_config.yml) apply.
# Otherwise, this overrides the setting from the global configuration (serena_config.yml).
# This setting can, in turn, be overridden by CLI parameters (--mode).
default_modes:

# initial prompt for the project. It will always be given to the LLM upon activating the project
# (contrary to the memories, which are loaded on demand).
initial_prompt: ""

# time budget (seconds) per tool call for the retrieval of additional symbol information
# such as docstrings or parameter information.
# This overrides the corresponding setting in the global configuration; see the documentation there.
# If null or missing, use the setting from the global configuration.
symbol_info_budget:

# list of regex patterns which, when matched, mark a memory entry as read‑only.
# Extends the list from the global configuration, merging the two lists.
read_only_memory_patterns: []

# list of regex patterns for memories to completely ignore.
# Matching memories will not appear in list_memories or activate_project output
# and cannot be accessed via read_memory or write_memory.
# To access ignored memory files, use the read_file tool on the raw file path.
# Extends the list from the global configuration, merging the two lists.
# Example: ["_archive/.*", "_episodes/.*"]
ignored_memory_patterns: []

# advanced configuration option allowing to configure language server-specific options.
# Maps the language key to the options.
# Have a look at the docstring of the constructors of the LS implementations within solidlsp (e.g., for C# or PHP) to see which options are available.
# No documentation on options means no options are available.
ls_specific_settings: {}
30 changes: 30 additions & 0 deletions Tiltfile
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,36 @@ for svc in ACTIVE_SERVICES:
labels=["services"],
)

# ============================================================================
# Nominations Saga Worker
# ============================================================================

docker_build(
"midstreamhub/nominations-saga",
context=".",
dockerfile="docker/Dockerfile.nominations-saga",
only=[
"docker/certs",
"src/MidstreamHub.sln",
"src/Directory.Build.props",
"src/Directory.Packages.props",
"src/StyleCopAnalyzers.ruleset",
"src/stylecop.json",
"src/nuget.config",
"local-nuget",
"src/Shared",
"src/Nominations/MidstreamHub.Nominations.Saga",
],
)

k8s_yaml("k8s/services/nominations-saga.yaml")

k8s_resource(
"nominations-saga",
resource_deps=["nservicebus-migrations", "nominations-migrations", "rabbitmq"],
labels=["services"],
)

# ============================================================================
# React Frontend
# ============================================================================
Expand Down
2 changes: 2 additions & 0 deletions build/_build.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="NuGet.Packaging" Version="7.3.1" />
<PackageReference Include="Nuke.Common" Version="10.1.0" />
<PackageReference Include="System.Security.Cryptography.Xml" Version="10.0.7" />
</ItemGroup>

</Project>
Loading