fix: add AllTests Nuke target for unit + integration tests#4
Merged
Conversation
…tion - Publish NominationSubmitted (Contracts.Messages) instead of NominationCreated so the saga actually starts when a nomination is created - Add BalanceAdjustmentCompleted handler and correlation to saga - Add NominationId to BalanceAdjustmentCompleted event for saga correlation - Remove orphaned MidstreamHub.Nominations.Messages package - Create nsb schema in all migration job init containers so NServiceBus SQL Persistence can create its tables via EnableInstallers() Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Create nsb schema and NominationFulfillmentSaga persistence table via Fluent Migrator instead of relying on EnableInstallers() and init container scripts. Follows the same two-project pattern (Migrations + Migrations.Runner) as the other services. - New MidstreamHub.NServiceBus.Migrations with M0001_CreateNsbSchema - New MidstreamHub.NServiceBus.Migrations.Runner with nsb VersionTable - New K8S job: nservicebus-migrations - Tiltfile: standalone docker_build/k8s_resource, API deps updated - Removed nsb schema creation from service init containers Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace the Movements placeholder with a full-featured page:
- Data table with 5s polling so movements appear automatically
- Right-side slide-in drawer showing full movement details and measurement data
- Inline confirm form for Delivered-status movements (PUT /api/movements/{id}/confirm)
- Movement-specific status badge colors (Scheduled=blue, InTransit=purple, Delivered=orange, Confirmed=green, Rejected=red)
- Dashboard wired with real movement counts and activity feed events
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…configmap) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
20-task plan across 3 workstreams: Accounting service backend (CLEAN architecture, NServiceBus handlers, migrations, K8S/Tilt), saga steps 3-6 completion, and Accounting UI + Dashboard update. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ed event Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…num, repository interface Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…djustment Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…djustment, completion Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ariance coloring Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…gress, Complete Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…s, DTOs Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…letion paths Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ds, activity feed Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…minationsApiClient Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…le, version metadata Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…itiateBalanceAdjustment Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…es, solution registration Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ss, Completed transitions Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The default Nuke target only ran unit tests (Category=Unit), silently skipping all integration tests. Add an AllTests target that depends on both Test and IntegrationTest, make it the default, and update CI workflow and Claude configuration to use it. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…usBadge types Enable full saga demo flow by adding BeginTransit and DeliverMovement commands/handlers/endpoints so movements can transition through Scheduled -> InTransit -> Delivered -> Confirmed. Localize all DateTime.UtcNow to DateTime.Now since all containers run on the local demo machine. Relax nomination date validator to allow today's date. Fix StatusBadge CI build by adding BalancePeriodStatus to the type union. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AllTestsNuke target that depends on bothTest(unit) andIntegrationTesttargetsAllTeststhe default Nuke target sonukeruns the full test suiteAllTestsinstead ofTestTest plan
nukelocally and verify both unit and integration tests executenuke Teststill runs only unit tests when invoked directlynuke IntegrationTeststill runs only integration tests when invoked directly🤖 Generated with Claude Code