Skip to content

Complete overhaul of preprocessing code #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
ewquon wants to merge 27 commits into
base: main
Choose a base branch
from
Draft

Complete overhaul of preprocessing code #36

ewquon wants to merge 27 commits into from

Conversation

@ewquon
Copy link
Contributor

@ewquon ewquon commented Sep 4, 2025

  • Remove tons of duplicated code
  • Refactor and cleanup for clarity and maintainability
  • Update package information (pyproject.toml instead of setup.py)
  • Automate command-line script generation

ewquon added 26 commits September 3, 2025 16:39
@ewquon
Fix syntax error
cf0130a
@ewquon
Start with some reorg
61543c2
@ewquon
Remove duplicated code, create utils.microphysics
e57c7e4
@ewquon
Remove duplicate code, create utils.projection
4bdf44c
@ewquon
Use erf.constants module, which is constant with ERF
0f7c10e
@ewquon
Move EOS to utils (to mimic ERF source)
3a4fbfa
@ewquon
Remove duplicated code, create utils.latlon
46dd51c
@ewquon
Remove duplicated code; create io.simple
e6bb8eb 
for "simple" ERF output format
@ewquon
Remove duplicated code, create io.vtk
e4dca15 
Note: these two write functions are mostly identical
@ewquon
Create generalized write_binary_structured_vtk and wrappers
c976f84 
for backwards compatibility with clearer names:

- `write_binary_vtk_on_native_grid`
  (formerly `write_binary_vtk_structured_grid`)
- `write_binary_vtk_on_cartesian_grid`
  (formerly `write_binary_vtk_structured_file`)
@ewquon
Update deps/versions, add pyproject.toml, update README
7ea7c84 
Also, remove legacy setup.py; warn if no cdsapi installed
@ewquon
Add install instructions
04da135
@ewquon
Update deps
da6b71b
@ewquon
Cleanup, add option to select GFS data product
30cb446
@ewquon
Cleanup
caeb7ec
@ewquon
Get rid of wildcard import
33cc1c1
@ewquon
Don't download if local gribfile found
8d2151b
@ewquon
Cleanup; clarify era5 nz levels
977786e
@ewquon
Remove many duplicated code snippets, add create_lcc_mapping
5fc7491 
to utils.projection
@ewquon
Get rid of another wildcard import; cleanup
6631d8a
@ewquon
Cleanup, slightly generalize write_binary_simple_erf
70b844c
@ewquon
Create subpackage for common data; remove duplicated plot_1d; fix whi…
f2a012e 
…tespace
@ewquon
Update gitignore
4feb869
@ewquon
Remove more duplicated code, create utils.map
f565688
@ewquon
Cleanup, generalize, reorg functions related to write_US_map_vtk
6a2b683
@ewquon
Replace WriteUSMapLambertProj with automatically generated script
37d1c1d
@ewquon ewquon marked this pull request as draft September 4, 2025 19:56
ewquon added a commit to ewquon/erftools that referenced this pull request Sep 19, 2025
@ewquon
Cherry pick pyproject.toml, README from PR erf-model#36
3cfcaf9
ewquon added a commit that referenced this pull request Sep 19, 2025
@ewquon
Update WRF namelist translation (#42)
2fd8aab 
* Allow single dx,dy input

* Cleanup code with RealInit

* Fix timestep parsing logic; fix output intervals

* Add more output params, including auxhist2

* refinement_indicators already a list

* Revert to level 2.5 and add note about MYNN

* Update mp_physics input mapping

* Update log info

* Fix unknown param warning

* Rename MOST bc to SurfaceLayer

* Always write out erf.plt_file_1 sampling

* Add comment about default smag Cs

* Handle multiple wrfinput files

* Dont warn about additional nc_init_files

* Correctly output Smag2D opt

* Output max_level for each nest

* Parse lsm physics from wrf

* Fix nest indexing

* No need to output default substepping type

* Revert to SLM for usability at the moment

* Fix sfclay name

* Change default terrain_smoothing option

* amr.regrid_int --> erf.regrid_int

* Change output name to be automatically detected by paraview

* Add more flexible ascii output

* Correctly output terrain grids for different domains

* Rename for clarity

* Reorg modules for clarity

* Cherry pick pyproject.toml, README from PR #36

* Create wrf_namelist_to_erf console script

* Make datetime parsing more robust

* Fix handling of default plot vars

* Update mp_physics mappings

* Fix syntax

* Add radiation params; estiamte rad_freq_in_steps if needed

* Remove deprecated param

* Generalize o3vmr to be constant or column array

* Add check_erf_input script

* Add --tslist option to namelist converter

* Add CAM ozone data and notebook to process and check it

from WRF/run:
- ozone_lat.formatted
- ozone_plev.formatted
- ozone.formatted

* Add function to calculate interp weights for monthly data

Following `ozn_time_int` in WRF/phys/module_radiation_driver.F

Verified that the python version of ozn_time_int matches the original
fortran to machine double precision. Interpolating using the new
`monthly_interp_weights_from_date` is identical to the python port

* Add utils for getting zcc from an inputfile; estimating p(z)

* Add new radiation interp functions

* Make ERFParms start/stop datetime parms consistent with ERF

* More robust datetime input handling

* Create generate_ozone_profile script

* Add option to read in wrfinput WRFInputDeck.__init__; scrape map attrs

* Split console script into separate interp_ozone function; call to update erf.o3vmr

* Automatically calculate O3 profile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ewquon