Skip to content

Conversation

@kentcdodds
Copy link
Member

Fix CI typecheck failure in 03.primitive-types/02.solution.comparisons by widening variable types.


Open in Cursor Open in Web

Co-authored-by: me <me@kentcdodds.com>
@cursor
Copy link

cursor bot commented Jan 22, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@kentcdodds kentcdodds marked this pull request as ready for review January 22, 2026 07:01
@kentcdodds
Copy link
Member Author

@cursor there are still CI failures from this branch

@cursor
Copy link

cursor bot commented Jan 22, 2026

Thanks for the heads-up. I fixed the TS2367 comparisons by widening a/b to number in exercises/03.primitive-types/02.solution.comparisons/index.ts and pushed it; local npm run typecheck passes now.【F:/workspace/exercises/03.primitive-types/02.solution.comparisons/index.ts†L16-L25】【F:/opt/cursor/artifacts/typecheck-output.log†L1-L4】 The remaining failure looks like the 🎭 Test job—want me to dig into that next or should I just re-run CI to confirm?

Open in Cursor Open in Web

@kentcdodds kentcdodds merged commit 98198c2 into main Jan 22, 2026
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants