Filters, shutters, and distance sensors #47
Conversation
…niblitz shutter controllers.
…cks. Added support for KeyenceCL3000 distance sensor.
.loglogin
Outdated
There was a problem hiding this comment.
This file should be deleted. It is created by scripts that are automatically run on APS linux machines.
There was a problem hiding this comment.
Common to add .loglogin to the repostory's .gitignore file. GitHub makes it possible to provide an organization-wide set of features (workflows, for example). The Bluesky team has been discussing adding a org-level .gitignore (in the BCDA-APS org) that would include .DS_Store, .loglogin, and some other common things one would not normally keep in a repo (such as .vscode).
There was a problem hiding this comment.
Change this:
iocsh/
To this:
/iocsh/
So that only the top-level, autogenerated iocsh dir is ignored.
kmpeters
left a comment
kmpeters
left a comment
There was a problem hiding this comment.
I'm comfortable merging this pull request.
|
@prjemian are there any other changes you think should be made before this PR is merged? |
prjemian
left a comment
prjemian
left a comment
There was a problem hiding this comment.
Changes in .gitignore look right. I'm skipping review of the other changes.
Adding support for serial-based XIA PFCU filters; Keyence CL3000 distance sensor; Thorlabs SC-10 shutter controller; and Uniblitz shutter controllers.