-
Notifications
You must be signed in to change notification settings - Fork 44
Fetch epicsEnvVars data from CONFIG_ENV in EPICS base #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c0c5044 to
56f5735
Compare
56f5735 to
5ca094e
Compare
|
One downside about this, comparing the output before and after: we get a bunch of PV renames. That is, we switch from (for example)
The upside is that we are much more explicit about the PV names in relation to the underlying EPICS variables. The downsides are that:
Thoughts, @nariox, @anjohnson ? |
|
I do like having the PV name match the underlying variable. As for the length, I don't mind the increase as much. From what I understand, the PV name length was limited to 40 chars up to base 3.12, after that the limit is 60 chars. ":CAS_AUTO_BEACON_ADDR_LIST" takes 26, which is quite a lot for someone using 3.12, but I think is fine for the 60 char limit. I imagine most people running the latest We could choose to ship the aliases for a single release cycle (3.3.x, but not 3.4.x), if we'd like to deprecate the old names eventually. I personally don't mind just keeping the aliases in (or maintaining it separately in my repo as long as the community has access to it if they want to find it). The aliases themselves are ready at #70. I have tried to look into a way to print a message when loading the aliases, but I couldn't find anything that wasn't too "hacky". Maybe creating a simple device support device that prints a deprecation warning in it's init function? Although I think it's not too much to expect maintainers to read the release notes carefully. You do touch a good point on the facility specific rules, but I think it is okay to have the local maintainers create their own custom iocEnvVar.template or have it patched by adding something like |
|
@nariox - I have updated this PR to add aliases to the old records, together with a deprecation note. Please let me know if this would work for you. |
|
Hi Simon, |
|
I have resubmitted the duplicate removal as #74. |
Resolves #68