Skip to content

feat: Add validation for gitUrlPath to ensure it does not end with a space #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SergK merged 1 commit into from
Nov 5, 2025
Merged

feat: Add validation for gitUrlPath to ensure it does not end with a space #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/webhook/validation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@ func IsCodebaseValid(codebase *codebaseApi.Codebase) error {
return fmt.Errorf("versioning start from is required when versioning type is not default")
}

if strings.HasSuffix(codebase.Spec.GitUrlPath, " ") {
return fmt.Errorf("gitUrlPath should not end with space")
}

return nil
}

Expand Down
44 changes: 27 additions & 17 deletions pkg/webhook/validation_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ import (
)

func TestIsCodebaseValid(t *testing.T) {
t.Parallel()

type args struct {
cr *codebaseApi.Codebase
}
Expand Down Expand Up @@ -53,9 +51,8 @@ func TestIsCodebaseValid(t *testing.T) {
Status: codebaseApi.CodebaseStatus{},
},
},
want: func(t require.TestingT, err error, i ...interface{}) {
require.Error(t, err)
require.Contains(t, err.Error(), "provided unsupported repository strategy: test-strategy")
want: func(t require.TestingT, err error, i ...any) {
require.ErrorContains(t, err, "provided unsupported repository strategy: test-strategy")
},
},
{
Expand All @@ -71,9 +68,8 @@ func TestIsCodebaseValid(t *testing.T) {
Status: codebaseApi.CodebaseStatus{},
},
},
want: func(t require.TestingT, err error, i ...interface{}) {
require.Error(t, err)
require.Contains(t, err.Error(), "provided unsupported language: test-lang")
want: func(t require.TestingT, err error, i ...any) {
require.ErrorContains(t, err, "provided unsupported language: test-lang")
},
},
{
Expand All @@ -92,17 +88,35 @@ func TestIsCodebaseValid(t *testing.T) {
Status: codebaseApi.CodebaseStatus{},
},
},
want: func(t require.TestingT, err error, i ...interface{}) {
require.Error(t, err)
require.Contains(t, err.Error(), "versioning start from is required when versioning type is not default")
want: func(t require.TestingT, err error, i ...any) {
require.ErrorContains(t, err, "versioning start from is required when versioning type is not default")
},
},
{
name: "should fail on gitUrlPath ending with space",
args: args{
cr: &codebaseApi.Codebase{
TypeMeta: metaV1.TypeMeta{},
ObjectMeta: metaV1.ObjectMeta{},
Spec: codebaseApi.CodebaseSpec{
Lang: "go",
Strategy: "create",
GitUrlPath: "/path/to/repo ",
Versioning: codebaseApi.Versioning{
Type: codebaseApi.VersioningTypDefault,
},
},
Status: codebaseApi.CodebaseStatus{},
},
},
want: func(t require.TestingT, err error, i ...any) {
require.ErrorContains(t, err, "gitUrlPath should not end with space")
},
},
}

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
t.Parallel()

err := IsCodebaseValid(tt.args.cr)

tt.want(t, err)
Expand All @@ -111,8 +125,6 @@ func TestIsCodebaseValid(t *testing.T) {
}

func Test_validateCodBaseName(t *testing.T) {
t.Parallel()

tests := []struct {
name string
codBaseName string
Expand All @@ -132,8 +144,6 @@ func Test_validateCodBaseName(t *testing.T) {

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
t.Parallel()

tt.wantErr(t, validateCodBaseName(tt.codBaseName))
})
}
Expand Down