v8: add pre-built V8 library build and distribution infrastructure#3872
Draft
jwendell wants to merge 1 commit intoenvoyproxy:mainfrom
Draft
v8: add pre-built V8 library build and distribution infrastructure#3872jwendell wants to merge 1 commit intoenvoyproxy:mainfrom
jwendell wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
Add the build script, repository rule, and module extension for building V8's wee8 static library from source and distributing it as a pre-built artifact for consumption by Envoy. - build_v8.sh: builds V8 in the self-contained bazel/v8/build/ workspace using a hermetic LLVM 18.1.8 toolchain with glibc 2.31 sysroot, collects PIC object files, and packages them with headers into a tarball. - v8_libs.bzl: repository rule that downloads (or extracts locally via V8_PREBUILT_PATH env var) the pre-built tarball, auto-detects host architecture, and exposes @v8//:wee8 with all required V8 defines. - extensions.bzl: bzlmod module extension for configuring the pre-built V8 library with per-architecture SHA256 hashes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Jonh Wendell <jwendell@redhat.com>
✅ Deploy Preview for nifty-bassi-e26446 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
phlax
reviewed
Mar 18, 2026
Member
phlax
left a comment
phlax
left a comment
There was a problem hiding this comment.
initial review ...
if you look at the bazel .github wf/s you should see how it can auto fish the built libs out of the bazel build
| # tree and copy only what's needed. | ||
| python3 -c " | ||
| import re, os, shutil, sys | ||
| v8_root = sys.argv[1] |
Member
There was a problem hiding this comment.
can we put the python in a python file - also you cant just call python - it would need the python toolchain to be available
also not seeing where this is actually called
| @@ -0,0 +1,45 @@ | |||
| """Module extension for pre-built V8 library configuration in bzlmod.""" | |||
|
|
|||
| load(":v8_libs.bzl", "v8_prebuilt") | |||
Member
There was a problem hiding this comment.
this is the bit i would hold off on in this pr - lets get the libs building then look at how to access them workspace/bzlmod
| ) | ||
| """ | ||
|
|
||
| def _v8_prebuilt_impl(ctx): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the build script, repository rule, and module extension for building V8's wee8 static library from source and distributing it as a pre-built artifact for consumption by Envoy.