Add libtinfo5 compatibility patch for LLVM < 19 on Ubuntu 24.04+ #3589
+55
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM < 19 depends on
libtinfo.so.5, which is absent from Ubuntu 24.04+ (replaced bylibtinfo6). This causes build failures:error while loading shared libraries: libtinfo.so.5: cannot open shared object file.Changes
Added patch
libtinfo5_fix.patchtotoolchains_llvm1.6.0.envoy:toolchain/internal/repo.bzl: Downloadslibtinfo5from Ubuntu 22.04 archives (amd64/aarch64) and extractslibtinfo.so.5.9when:toolchain/cc_wrapper.sh.tpl: PrependsLD_LIBRARY_PATHwith toolchain's lib directory on Linux:Updated
source.json: Added patch with SHA256 checksum.Details
.deb archives sourced from Ubuntu 22.04:
http://security.ubuntu.com/ubuntu/pool/universe/n/ncurses/libtinfo5_6.3-2ubuntu0.1_amd64.debhttp://ports.ubuntu.com/pool/universe/n/ncurses/libtinfo5_6.3-2ubuntu0.1_arm64.debVerified checksums match upstream package database.
Upstream tracking: bazel-contrib/toolchains_llvm#528
Original prompt
This pull request was created from Copilot chat.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.