Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 10, 2025

Aggregate Passing Renovate PRs

✅ All 5 passing renovate PRs have been successfully cherry-picked, built, and tested.

Summary of Changes:

  • Updated 19 files across 9 gh-actions directories
  • Net reduction of ~811 lines (package-lock.json optimization)
  • Fixed fetch-mock API compatibility (v11 → v12)
    • Changed sandbox() to createInstance()
    • Properly bound fetchHandler method for mock fetch function
  • All builds, tests, and linting checks pass without errors
Original prompt

there are a few renovate pr in this repo that are passing ci - can you see which ones?

if you can - can you please create an aggregation pr so that we can land them all together

if you cant - dont worry - this wont work

if some of the prs change the same file then you want to pick them in reverse order so as not to create conflicts

do NOT pick either the mypy or docutils prs

do NOT add an initial commit or any commits other than the picked ones (squash any related changes to the picked commits if needed)

js deps might need to be rebuilt if they are changing the expected build


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@netlify
Copy link

netlify bot commented Dec 10, 2025

Deploy Preview for nifty-bassi-e26446 ready!

Name Link
🔨 Latest commit 1fa78fe
🔍 Latest deploy log https://app.netlify.com/projects/nifty-bassi-e26446/deploys/6939f6890eca210008331b1c
😎 Deploy Preview https://deploy-preview-3006--nifty-bassi-e26446.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot AI changed the title [WIP] Create aggregation PR for passing renovate PRs Aggregate passing renovate PRs (eslint, typescript-eslint, @octokit/types, @types/node, fetch-mock) Dec 10, 2025
Copilot AI requested a review from phlax December 10, 2025 18:11
@phlax
Copy link
Member

phlax commented Dec 10, 2025

@copilot ```

@envoy/toolshed/actions/retest@1.0.0 test
tsc --noEmit && jest

console.log
12345

  at RetestCommands.get env (retest.ts:292:13)

console.error
fetch is not a function

  411 |   } catch (error) {
  412 |     if (error instanceof Error) {
> 413 |       console.error(error.message)
      |               ^
  414 |     }
  415 |     core.setFailed(`retest-action failure: ${error}`)
  416 |   }

  at run (retest.ts:413:15)
  at Object.<anonymous> (__tests__/retest.test.ts:42:5)

Error: retest-action failure: TypeError: fetch is not a function
console.log
12345

  at RetestCommands.get env (retest.ts:292:13)

console.error
fetch is not a function

  411 |   } catch (error) {
  412 |     if (error instanceof Error) {
> 413 |       console.error(error.message)
      |               ^
  414 |     }
  415 |     core.setFailed(`retest-action failure: ${error}`)
  416 |   }

  at run (retest.ts:413:15)
  at Object.<anonymous> (__tests__/retest.test.ts:47:5)

Error: retest-action failure: TypeError: fetch is not a function

Copy link
Contributor Author

Copilot AI commented Dec 10, 2025

@copilot ```

@envoy/toolshed/actions/retest@1.0.0 test
tsc --noEmit && jest...

Fixed in 27efc5b. The issue was that createInstance() returns a FetchMock instance, but we need to pass its bound fetchHandler method as the fetch function. Changed from:

{request: {fetch: githubMock}}

to:

{request: {fetch: githubMock.fetchHandler.bind(githubMock)}}

Tests now pass without the "fetch is not a function" errors.

@phlax phlax force-pushed the copilot/aggregate-renovate-prs branch from 27efc5b to 1fa78fe Compare December 10, 2025 22:39
@phlax phlax marked this pull request as ready for review December 10, 2025 22:39
@phlax phlax merged commit d185bc2 into main Dec 10, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants