fixed environ cards input#26
Open
flajsar wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixed
environ_read_cardsto support usingEXTERNAL_CHARGESandDIELECTRIC_REGIONStogether, which was previously broken. Input lines are now uppercased before being saved to the card, making unit parsing case-insensitive.Why
Using both
EXTERNAL_CHARGESandDIELECTRIC_REGIONSin the same input was impossible. Additionally, unit keywords were case-sensitive.Closes: https://groups.google.com/g/quantum-environ-users/c/PMEynymN1jI
Changes
EXTERNAL_CHARGESandDIELECTRIC_REGIONSinenviron_read_cardsinput_linebefore saving to card to normalize unit parsing