Rename package from hypersync-temp back to hypersync for PyPI#54
Rename package from hypersync-temp back to hypersync for PyPI#54
Conversation
📝 WalkthroughWalkthroughThe package name is consolidated from the temporary Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Waiting for a publish! https://github.com/enviodev/hypersync-client-python/actions/runs/23444557341 |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/publish.yml (1)
133-143: Consider adding anenvironmentfor the release job.While OIDC trusted publishing will work without an explicit
environment, adding one provides an additional layer of security through GitHub's environment protection rules (e.g., required reviewers, deployment branches).♻️ Optional: Add environment for deployment protection
release: name: Release runs-on: ubuntu-latest + environment: pypi needs: [linux, windows, macos, sdist] steps:This requires configuring a
pypienvironment in GitHub repository settings and updating the PyPI trusted publisher to reference this environment.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/publish.yml around lines 133 - 143, Add a GitHub Actions environment to the release job by updating the job named "release" to include an environment (e.g., environment: pypi) so the job is subject to repository environment protection rules; update the workflow near the job that calls PyO3/maturin-action@v1 (the "Publish to PyPI" step) and ensure you have configured a corresponding "pypi" environment in the repo settings and adjusted the PyPI trusted publisher to reference that environment.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/publish.yml:
- Around line 133-143: Add a GitHub Actions environment to the release job by
updating the job named "release" to include an environment (e.g., environment:
pypi) so the job is subject to repository environment protection rules; update
the workflow near the job that calls PyO3/maturin-action@v1 (the "Publish to
PyPI" step) and ensure you have configured a corresponding "pypi" environment in
the repo settings and adjusted the PyPI trusted publisher to reference that
environment.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 05fe4120-ef16-435e-b6c0-857ca578b947
📒 Files selected for processing (3)
.github/workflows/publish.ymlREADME.mdpyproject.toml
💤 Files with no reviewable changes (1)
- README.md
|
Working - merging |
Summary by CodeRabbit
Documentation
Chores
hypersync-temptohypersync. Users should reinstall using the official package name.