Deduplicate 'any' version attribute#286
Open
leonardehrenfried wants to merge 1 commit intoentur:masterfrom
Open
Deduplicate 'any' version attribute#286leonardehrenfried wants to merge 1 commit intoentur:masterfrom
leonardehrenfried wants to merge 1 commit intoentur:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EPIP allows you to use the version
anyand some feeds us it for every entity.In my particular example at hand the string
anyis duplicated 72 million times!For this reason, I'm implementing a very simple version de-duplicator which checks for the version "any".
If desired, this could also be a bit more aggressive by, for example, deduplicating purely numeric versions from 0-100.
cc @vpaturet
Ref: #284
Ref: noi-techpark/opendatahub-mentor-otp#273
cc @rcavaliere