Open
Conversation
vpaturet
requested changes
Mar 18, 2026
Contributor
vpaturet
left a comment
vpaturet
left a comment
There was a problem hiding this comment.
Looks good.
Could you document:
- thread safety: why it works.
- memory leak: why this is a limited risk.
| } | ||
|
|
||
| @Test | ||
| public void testCaching() { |
Contributor
There was a problem hiding this comment.
Could you add a test with different variants like: "10:20:30" vs "10:20:30+02:00"?
Author
|
I'm actually not sure how many threads are using the adapter concurrently. If there is a chance that it's multiple, we can synchronize the map map or use a concurrent one. Any opinions? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements deduplication of instances of
LocalTime.This is okay, because it's an immutable value object where one instance truly can be replaced with an equal one.
Improvement
In my current example file this can cut down the number of instances from around 30 million to a few thousand, saving around 800MB of RAM!
cc @vpaturet
Ref: #284
Ref: noi-techpark/opendatahub-mentor-otp#273
cc @rcavaliere