Skip to content

Mapbase Pose Param Bounds Check #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1upD merged 3 commits into from
May 21, 2026
Merged

Mapbase Pose Param Bounds Check #360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9af81e
Fix lack of bounds checking in pose parameter functions
Blixibon May 16, 2026
2edf4ed
Fix incorrect logic in bounds checking fix
Blixibon May 17, 2026
d9fd335
Add "-noscripting_client" launch parameter for disabling clientside V…
Blixibon May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sp/src/game/client/c_baseanimating.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1468,7 +1468,7 @@ float C_BaseAnimating::GetPoseParameter( int iPoseParameter )
if ( pStudioHdr->GetNumPoseParameters() < iPoseParameter )
return 0.0f;

if ( iPoseParameter < 0 )
if ( iPoseParameter < 0 || iPoseParameter >= MAXSTUDIOPOSEPARAM )
return 0.0f;

return m_flPoseParameter[iPoseParameter];
Expand Down Expand Up @@ -6054,7 +6054,7 @@ float C_BaseAnimating::SetPoseParameter( CStudioHdr *pStudioHdr, int iParameter,
return flValue;
}

if (iParameter >= 0)
if (iParameter >= 0 && iParameter < MAXSTUDIOPOSEPARAM)
{
float flNewValue;
flValue = Studio_SetPoseParameter( pStudioHdr, iParameter, flValue, flNewValue );
Expand Down
2 changes: 1 addition & 1 deletion sp/src/game/client/cdll_client_int.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -967,7 +967,7 @@ int CHLClient::Init( CreateInterfaceFn appSystemFactory, CreateInterfaceFn physi
if (!g_pMatSystemSurface)
return false;

if ( !CommandLine()->CheckParm( "-noscripting") )
if ( !CommandLine()->CheckParm( "-noscripting" ) && !CommandLine()->CheckParm( "-noscripting_client" ) )
{
scriptmanager = (IScriptManager *)appSystemFactory( VSCRIPT_INTERFACE_VERSION, NULL );

Expand Down
Loading