Fix incorrect damage scaling behavior in CPropDrivableAPC::OnTakeDamage #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves an issue with EZ's version of
vehicle_drivable_apcwhere players would end up taking marginally more damage when crouching/hiding in the drivers seat because of a mistake with the original implementationI've updated the comments but the short version is that the APC's
m_flViewLoweredvalue operates in the range of [-10, 0] rather than [0, 10], resulting in the player taking 0.75% more damage per hit rather than the (I'm assuming) intended behavior of taking half the value ofsk_apc_damage_normalinstead (e.g. 7.5% damage instead of 15%)