fix: validate GitHub user data before caching #111
Closed
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent caching incomplete user data that's missing required fields (id, created_at). This prevents crashes when later code tries to access these fields. Changes: - Added validation before caching user data in get_github_user() - Returns data without caching if required fields are missing - Added descriptive warning log for debugging Contribution by Gittensor, learn more at https://gittensor.io/
Collaborator
|
have you observed any times when the github api has returned incomplete responses? this seems like an unnecessary edge case solution |
Contributor
Author
Thank you for your reply. You mean my changes are unnecessary for this repository? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent caching incomplete user data that's missing required fields (id, created_at). This prevents crashes when later code tries to access these fields.
Changes:
Contribution by Gittensor, learn more at https://gittensor.io/