fix(queue): evict failed PR_FILES jobs#128
Open
JSONbored wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #124
Summary
PR_FILESjobs immediately so retained failures do not keep owning deterministic job IDs.PR_METADATAalready uses after fix(webhook): don't retain failed PR metadata jobs #118.Why
PR_FILESjobs use deterministic IDs by repo, PR number, head SHA, and base SHA. If one of those jobs exhausts retries whileremoveOnFailretains it in BullMQ, a later same-generation refresh can be skipped because the failed job still owns the custom ID.This keeps pending and active jobs deduped, but lets a later webhook, backfill, or worker-side requeue enqueue a fresh files refresh after failure details have already gone to service logs.
Test plan
npm run format:checknpm run lintnpm run buildgit diff --check