Open
Conversation
Entire-Checkpoint: c8bb257f3d46
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a default timeout around AI summary generation to prevent the explain --generate (and other shared summarization call sites) from hanging indefinitely.
Changes:
- Add a 30s context timeout wrapper inside
summarize.GenerateFromTranscript. - Improve Claude CLI generator error handling to surface context cancellation/timeouts consistently.
- Update
explainsummary generation to emit a user-facing “Generating…” message and add a unit test for timeout behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| cmd/entire/cli/summarize/summarize.go | Adds a default timeout and timeout-specific error handling around generator execution. |
| cmd/entire/cli/summarize/generator_config_test.go | Adds a new unit test intended to validate timeout behavior. |
| cmd/entire/cli/summarize/claude.go | Returns context.DeadlineExceeded / context.Canceled when the context ends during Claude CLI execution. |
| cmd/entire/cli/explain.go | Wires through an error writer and prints progress text while generating a checkpoint summary. |
Entire-Checkpoint: 512e7cbbecb7
Contributor
Author
|
@BugBot review |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 1b2851e. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Adds a timeout to checkpoint summary generation for
entire explain --generateso the command cannot hang indefinitely when the Claude CLI stalls.What Changed
explain --generateinexplain.gosummarize.GenerateFromTranscriptgeneric for other call sitesGenerating checkpoint summary...whileexplain --generateis waitingWhy
A stalled Claude summary generation path currently leaves users waiting without a bounded failure mode. This change keeps the fix narrowly scoped to
explain --generateinstead of changing shared summarize behavior for other callers.Current state before this fix:
entire explain --generate^Cfailed to generate summary: failed to generate summary: claude CLI failed (exit -1):Verification
go test ./cmd/entire/cli -run 'TestGenerateCheckpointAISummary|TestExplainCmd_RejectsPositionalArgs'go test ./cmd/entire/cli/summarizemise run lintmise run test