Skip to content

Commit 1: Attempt 1#1

Open
enterprise378 wants to merge 1 commit into
mainfrom
assignment-1
Open

Commit 1: Attempt 1#1
enterprise378 wants to merge 1 commit into
mainfrom
assignment-1

Conversation

@enterprise378
Copy link
Copy Markdown
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Adding code and answers

What did you learn from the changes you have made?

There may be different seed functions for different packages.

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

No

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

Wrong seed function used at first

How were these changes tested?

Code executed

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link
Copy Markdown

@namraschazil namraschazil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!
Overall a good explanation of the sampling steps with reasoning, and addition of random seed to enhance reproducibility.

Pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants