Commit 1: Attempt 1#1
Open
enterprise378 wants to merge 2 commits into
Open
Conversation
Shiraz-Latif
suggested changes
Apr 24, 2026
Shiraz-Latif
left a comment
Shiraz-Latif
left a comment
There was a problem hiding this comment.
in cell [28], when you split the data, you used the original X (unscaled data) instead of predictors_standardized --> that lead to much lower accuracy of 0.7 instead of expected 0.9
Resubmit please.
Owner
Author
|
Hi Shiraz,
Thank you for pointing this out. I have resubmitted the assignment.
Best regards,
Peter
From: Shiraz-Latif ***@***.***>
Date: Friday, April 24, 2026 at 12:08 AM
To: enterprise378/LCR ***@***.***>
Cc: Peter Wu ***@***.***>; Author ***@***.***>
Subject: Re: [enterprise378/LCR] Commit 1: Attempt 1 (PR #1)
@Shiraz-Latif requested changes on this pull request.
in cell [28], when you split the data, you used the original X (unscaled data) instead of predictors_standardized --> that lead to much lower accuracy of 0.7 instead of expected 0.9
Resubmit please.
—
Reply to this email directly, view it on GitHub<#1?email_source=notifications&email_token=BQIR66B3UDJKONMNR6D5SGD4XLSCNA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMJWG43TKNZTGM42M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2L24DSL5ZGK5TJMV3V63TPORUWM2LDMF2GS33OONPWG3DJMNVQ#pullrequestreview-4167757339>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BQIR66CLSYPKKPSKDDCO4VD4XLSCNAVCNFSM6AAAAACYAEBP7SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DCNRXG42TOMZTHE>.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS<https://github.com/notifications/mobile/ios/BQIR66GCNR7BAR4RK5GNRZL4XLSCNA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMJWG43TKNZTGM42M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG> and Android<https://github.com/notifications/mobile/android/BQIR66DP65J3PF6QWJBB6EL4XLSCNA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMJWG43TKNZTGM42M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>. Download it today!
You are receiving this because you authored the thread.
|
Shiraz-Latif
approved these changes
Apr 27, 2026
Shiraz-Latif
left a comment
Shiraz-Latif
left a comment
There was a problem hiding this comment.
Thanks for incorporating the feedback.
Assignment is complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Adding code
What did you learn from the changes you have made?
Clearly identifying features and response variables are important.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
No
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Remembering the steps to train a KNN model.
How were these changes tested?
The code was executed and the outputs verified.
A reference to a related issue in your repository (if applicable)
Checklist