DRAFT: Refactor game state#2235
Draft
wjt wants to merge 1 commit into
Draft
Conversation
GameState mixes the actual load/save logic with the state itself, and
also is based on a mixture of directly accessing the contents of a
ConfigFile object and fields of the GameState node.
Factor all the state itself out to a tree of Resource subclasses:
- Global state
- Player state
- Quest state (nullable)
- Quest-specific player state
- Scene state
Replace the ConfigFile-based load/save logic with
ResourceLoader/ResourceSaver. This avoids writing bespoke serialisation
code & makes it easy to add new saved fields – drop an @export into the
appropriate state class – at the cost of tightly coupling the savegame
format to the game's internals.
#2016
|
Play this branch at https://play.threadbare.game/branches/endlessm/wjt/refactor-game-state/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT: Refactor game state
GameState mixes the actual load/save logic with the state itself, and
also is based on a mixture of directly accessing the contents of a
ConfigFile object and fields of the GameState node.
Factor all the state itself out to a tree of Resource subclasses:
Replace the ConfigFile-based load/save logic with
ResourceLoader/ResourceSaver. This avoids writing bespoke serialisation
code & makes it easy to add new saved fields – drop an @export into the
appropriate state class – at the cost of tightly coupling the savegame
format to the game's internals.
#2016