HookControl: Disable keyboard aiming while mouse is in use#2101
Open
HookControl: Disable keyboard aiming while mouse is in use#2101
Conversation
Use a 3 seconds timeout to resume aiming with keyboard. This also happens to be the amount of seconds we keep the mouse cursor on screen in the MouseManager. This fixes an error in which the mouse and keyboard are competing for the aiming direction, making the grappling hook very hard to use. Credits for this feedback goes to Heather Drolet who complained about this in a playtest.
For hiding the mouse. The timer is already configured to wait 3 seconds.
|
Play this branch at https://play.threadbare.game/branches/endlessm/fix-grappling-aiming/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
Collaborator
Author
|
With this: (the video starts aiming with keyboard, then I switch to mouse) recording.webmWithout it, you can see how mouse and keyboard are competing: recording.webm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a 3 seconds timeout to resume aiming with keyboard. This also happens to be the amount of seconds we keep the mouse cursor on screen in the MouseManager.
This fixes an error in which the mouse and keyboard are competing for the aiming direction, making the grappling hook very hard to use. Credits for this feedback goes to Heather Drolet who complained about this in a playtest.
MouseManager: Do not hardcode wait_time in code
For hiding the mouse. The timer is already configured to wait 3 seconds.