chore(deps): bump @e4a/pg-js to ^1.8.0#223
Merged
Merged
Conversation
Contributor
Author
|
/dobby review |
Contributor
|
This agent is on it! Eager to review the pg-js 1.8 bump — checking CI, the lockfile, and the /download decrypt flow that the 1.7.1 fix touches. Will report back shortly. |
Contributor
There was a problem hiding this comment.
Approving. Pure dep bump to @e4a/pg-js@^1.8.0 (pulls @e4a/pg-wasm 0.6.0 transitively); no source changes.
Verified locally:
npm ci --legacy-peer-depsclean.npm run check— 0 errors, 0 warnings.npm run build— succeeds.- CI green (Build amd64/arm64, Lint, Svelte Check, Conventional Commit).
PR description accurately reflects upstream releases (confirmed against postguard-js v1.7.0/1.7.1/1.8.0 release notes):
- 1.7.1 zip-unwrap fix is the load-bearing change here —
pg.open({ uuid }).decrypt(...)is hit atsrc/routes/(app)/download/+page.svelte:64,116andsrc/lib/components/fallback/Decrypt.svelte:90,233. No call-site changes needed; the fix is transparent. - Skipping 1.7.0
resumeUpload/ 1.8.0onUploadInitis the right call: browserFilehandles can't survive a reload, so users would have to reselect files anyway. Wiring them up here would be UX theater.
Worth a manual smoke (encrypt → download round-trip) before merge per the test plan, but no code-level blockers.
Contributor
There was a problem hiding this comment.
Reviewed locally on chore/bump-pg-js-1.8:
npm ci --legacy-peer-depsclean,npm run check0 errors / 0 warnings,npm run buildsucceeds.- All seven CI checks already green.
- Diff is the dep bump only (
package.json+ lockfile). No call-site changes needed:/downloadkeeps casting toDecryptFileResultandDecrypt.sveltealready branches onresult.plaintextvsextractFromZip(blob, 'data.bin'), so the 1.7.1 unwrap fix just shifts more cases onto the plaintext branch — no regression surface. - Skipping the 1.7.0/1.8.0 resume primitives is the right call:
Sealed.upload()has no rehydration entry point and browserFilehandles don't survive reload anyway.
LGTM.
This was referenced May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@e4a/pg-jsfrom^1.6.2to^1.8.0(pulls@e4a/pg-wasm0.5.10 → 0.6.0 transitively).Opened.decrypt({ uuid })now unwrapsdata.binfrom the zip — directly affects our/downloadflow (pg.open({ uuid }).decrypt(...)).resumeUpload,onUploadInit). The high-levelSealed.upload()has no entry point to consume a rehydratedFileState, and browserFilehandles don't survive a reload — users would have to reselect files anyway, so the UX value is zero. Skipped intentionally.Test plan
npm run checkandnpm run buildpass locally on the bumped lockfile./and verify the upload completes end-to-end./downloaddecrypts to the original file (regression check for the 1.7.1 zip-unwrap fix).