Skip to content

chore: bump @e4a/pg-js to 1.10.0#107

Merged
rubenhensen merged 2 commits into
mainfrom
chore/bump-pg-js-1.10.0
May 25, 2026
Merged

chore: bump @e4a/pg-js to 1.10.0#107
rubenhensen merged 2 commits into
mainfrom
chore/bump-pg-js-1.10.0

Conversation

@dobby-coder
Copy link
Copy Markdown
Contributor

@dobby-coder dobby-coder Bot commented May 24, 2026

Bumps @e4a/pg-js from 1.8.0 to 1.10.0 (single minor jump; 1.9.0 → 1.10.0 chained through one npm install).

Verified npm run docs:build succeeds in 8.4s. No other test suite in this repo.

Closes #106

@dobby-coder dobby-coder Bot requested a review from rubenhensen May 24, 2026 22:15
Copy link
Copy Markdown
Contributor Author

@dobby-coder dobby-coder Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-authored, so cannot --approve. Verdict: LGTM, ready to merge from this reviewer's side.

Verified locally:

  • npm ci clean, 0 vulnerabilities
  • npm run docs:build succeeds in ~7s
  • CI build job passes

Heads-up (non-blocking): @e4a/pg-js@1.10.0 declares engines.node: ">=22", but Dockerfile still pins node:20-alpine. npm doesn't enforce engines by default, so the Docker build still passes — but a future tightening (e.g. engine-strict=true or pg-js dropping Node 20 syntactically) would break the prod image. Worth a follow-up bump to node:22-alpine at some point.

@e4a/pg-js@1.10.0 declares engines.node >=22; align the Docker build
image and README prerequisite accordingly.
Copy link
Copy Markdown
Contributor Author

@dobby-coder dobby-coder Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed the Node engine heads-up in 9e749c2:

  • Dockerfile: node:20-alpinenode:22-alpine (matches @e4a/pg-js@1.10.0 engines node >=22)
  • README prerequisite: Node.js 18+Node.js 22+

Verified npm ci + npm run docs:build still pass locally.

Copy link
Copy Markdown
Contributor Author

@dobby-coder dobby-coder Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-authored, so cannot --approve. Verdict: LGTM, ready to merge from this reviewer's side (review cycle 2/3).

Verified locally on cycle 2:

  • npm ci clean, 0 vulnerabilities
  • npm run docs:build succeeds in ~8s on Node 22
  • CI: build + Conventional Commit checks both pass

The engines heads-up from cycle 1 is addressed in 9e749c2: Dockerfile is now node:22-alpine and README prerequisite is Node.js 22+, matching @e4a/pg-js@1.10.0 (engines.node: >=22). Diff is tight (4 files, all expected for a pg-js minor bump + Node alignment). Nothing else to flag.

@rubenhensen rubenhensen merged commit fc2cbdf into main May 25, 2026
2 checks passed
@rubenhensen rubenhensen deleted the chore/bump-pg-js-1.10.0 branch May 25, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: update dependencies

1 participant