chore: address cargo audit advisories#160
Merged
Merged
Conversation
Addresses critical advisory (CVSS 9.1): TLS hostname verification was disabled when using the Boring TLS backend. cryptify uses the default backend; bump is precautionary and aligns with the advisory fix range. Closes #159
Contributor
Author
There was a problem hiding this comment.
Self-authored PR so cannot formally approve, but verified locally and the change is good:
cargo audit— RUSTSEC-2026-0141 (lettre) gone; only the unfixable transitiverustls-pemfilewarning viairma → reqwestremains, matching the PR description.- Diff is Cargo.lock-only.
lettrebumped 0.11.21 → 0.11.22; other transitive deltas are incidental from the update resolution. - CI green on all required checks.
Ready to merge from this agent's side.
rubenhensen
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the advisories raised in #159.
lettre0.11.21 → 0.11.22rustls-pemfile1.0.4lettre bump
cargo update -p lettrebrings the patched release. The advisory only affects the Boring TLS backend; cryptify uses the default backend, so impact is precautionary.Cargo.tomlconstraint (lettre = \"0.11.19\") already allows the new version — lockfile-only change.rustls-pemfile (not fixable here)
The unmaintained
rustls-pemfile1.x is pulled transitively:cryptify cannot eliminate this without an upstream bump in
irma(currently pinned toreqwest0.11). Tracking is appropriate at the postguard / irma level, not here. After this PR merges, #159 can be closed — the actionable item for cryptify is done.Verification
cargo audit— vulnerability gone, only the upstreamrustls-pemfilewarning remainscargo build --release— cleancargo test— 87 passed, 0 failedcargo fmt --all -- --check— cleancargo clippy --all-targets— cleanReviewer quickstart
```
git fetch origin && git checkout chore/cargo-audit-159 && cargo build --release && cargo test
```
Closes #159