Skip to content

Revert my own change that completely messes up typedefs in the dwarfdump #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dbalatoni13 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Revert my own change that completely messes up typedefs in the dwarfdump #133

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21704af
Revert my own change that completely messes up array typedefs
dbalatoni13 Jan 6, 2026
a3f649a
Fix formatting
dbalatoni13 Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions src/cmd/dwarf.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,22 +254,6 @@ where
// pre-parse step
for &child in &children {
preprocess_cu_tag(&info, child);

if let TagKind::Typedef = child.kind {
// TODO fundamental typedefs?
if let Some(ud_type_ref) =
child.reference_attribute(AttributeKind::UserDefType)
{
match typedefs.entry(ud_type_ref) {
btree_map::Entry::Vacant(e) => {
e.insert(vec![child.key]);
}
btree_map::Entry::Occupied(e) => {
e.into_mut().push(child.key);
}
}
}
}
}
for &child in &children {
let tag_type = match process_cu_tag(&info, child) {
Expand Down Expand Up @@ -309,6 +293,22 @@ where
continue;
}
}

if let TagKind::Typedef = child.kind {
// TODO fundamental typedefs?
if let Some(ud_type_ref) =
child.reference_attribute(AttributeKind::UserDefType)
{
match typedefs.entry(ud_type_ref) {
btree_map::Entry::Vacant(e) => {
e.insert(vec![child.key]);
}
btree_map::Entry::Occupied(e) => {
e.into_mut().push(child.key);
}
}
}
}
}
}
kind => bail!("Unhandled root tag type {:?}", kind),
Expand Down