Skip to content

perf: remove redundant .lower() calls in Headers #3735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shindonghwi wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

perf: remove redundant .lower() calls in Headers #3735

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions httpx/_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ def get_list(self, key: str, split_commas: bool = False) -> list[str]:
values = [
item_value.decode(self.encoding)
for _, item_key, item_value in self._list
if item_key.lower() == get_header_key
if item_key == get_header_key
]

if not split_commas:
Expand Down Expand Up @@ -334,7 +334,7 @@ def __delitem__(self, key: str) -> None:
pop_indexes = [
idx
for idx, (_, item_key, _) in enumerate(self._list)
if item_key.lower() == del_key
if item_key == del_key
]

if not pop_indexes:
Expand Down